Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 56667
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: JARIAALTO [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 1.108

History Show all quoted text
  Fri Apr 16 12:25:05 2010 JARIAALTO [...] cpan.org - Ticket created
Subject: No "$VERSION" variable found (false positive)
No "$VERSION" variable found at line 1, column 1. See page 404 of PBP. 1 #!/usr/bin/perl 2 use strict; 3 4 my $VERSION = '@@VERSION@@'; A file that will be "automake'd".
  Sat Apr 17 18:11:14 2010 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #56667] No "$VERSION" variable found (false positive)
Date: Sat, 17 Apr 2010 17:10:59 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
On 4/16/10 11:25 AM, Jari Aalto via RT wrote: Show quoted text
> No "$VERSION" variable found at line 1, column 1. See page 404 of PBP. > > 1 #!/usr/bin/perl > 2 use strict; > 3 > 4 my $VERSION = '@@VERSION@@'; > > A file that will be "automake'd".
Automake doesn't enter into this. I'd say that the messages wasn't clear enough, though. The problem is that you're saying "my $VERSION" and not "our $VERSION". Version number variables need to be package scoped.
  Sat Apr 17 18:11:16 2010 The RT System itself - Status changed from 'new' to 'open'
  Tue Apr 20 14:05:58 2010 wyant [...] cpan.org - Correspondence added
On Sat Apr 17 18:11:14 2010, clonezone wrote: Show quoted text
> > Automake doesn't enter into this. I'd say that the messages wasn't > clear enough, though. The problem is that you're saying "my > $VERSION" and not "our $VERSION". Version number variables need to > be package scoped.
Proposed clarification of the message and the POD committed as SVN revision 3800. All I did to the message was add "package-scoped". Other, better wordings are certainly possible, I just wanted to get something in the mill. Tom
  Wed Apr 21 21:06:50 2010 ELLIOTJS [...] cpan.org - Status changed from 'open' to 'patched'
  Sun Jun 27 15:19:47 2010 ELLIOTJS [...] cpan.org - Status changed from 'patched' to 'resolved'
  Sun Jun 27 15:19:47 2010 ELLIOTJS [...] cpan.org - Fixed in 1.108 added