Skip Menu |

This queue is for tickets about the Text-FIGlet CPAN distribution.

Report information
The Basics
Id: 56588
Status: resolved
Priority: 0/
Queue: Text-FIGlet

People
Owner: Nobody in particular
Requestors: folti78 [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 2.18
  • 2.11
  • 2.12
  • 2.13
  • 2.14
  • 2.16
  • 2.17
Fixed in: 2.19



Subject: some TOIlet fonts displayed with a column of '@' at ther right border
With Text-FIGlet-2.18 on Ubuntu Hardy x86_64. perl: This is perl, v5.10.0 built for x86_64-linux-gnu-thread-multi Some TOIlet fonts(especially the *mono(9|12) fonts), have an extra whitespace after the line ending '@' character, which are displayed by Text::FIGlet. Example using smmono12 font: @ @ @ @ @ @ @ @ ▗▄▖ @ ▗▄▖ @ @ ▗▄ @ ▗▄▖ @ @ ▄▄▖ @ ▄▄▖ @ █▀█ @ █▀█ @ @ ▟█ @ █▀▜ @ @ ▐▀▀█▖@ ▐▀▀█▖@ ▐▌ ▐▌@ ▐▌ ▐▌@ ▄ @ ▐▘█ @ ▐▌▄▖ @ ▄ @ ▟▌@ ▟▌@ ▐▌█▐▌@ ▐▌█▐▌@ █ @ ▗▛ █ @ ▐█▀█▖@ █ @ ▐██ @ ▐██ @ ▐▌ ▐▌@ ▐▌ ▐▌@ @ ▐███▌@ ▐▌ ▐▌@ @ ▜▌@ ▜▌@ █▄█ @ █▄█ @ █ @ █ @ ▝█▄█▘@ █ @ ▐▄▄█▘@ ▐▄▄█▘@ ▝▀▘ @ ▝▀▘ @ ▀ @ ▀ @ ▝▀▘ @ ▀ @ ▀▀▘ @ ▀▀▘ @ @ @ @ @ @ @ @ @ Attached patch strips superfluous whitespaces from these fonts, to prevent this.
Subject: figlet-Font.pm.diff
diff -Naur --exclude countdown.pl Text-FIGlet-2.18/lib/Text/FIGlet/Font.pm Text-FIGlet-2.18-my/lib/Text/FIGlet/Font.pm --- Text-FIGlet-2.18/lib/Text/FIGlet/Font.pm 2009-10-10 09:34:10.000000000 +0200 +++ Text-FIGlet-2.18-my/lib/Text/FIGlet/Font.pm 2010-04-13 15:24:17.000000000 +0200 @@ -203,6 +203,7 @@ $self->{_maxLen} = $length if $i < 126 && $self->{_maxLen} < $length; #Ideally this would be /o but then all figchar's must have same EOL + $font->[$i] =~ s/\@ $//mg; $font->[$i] =~ s/\015|\Q$end\E{1,2}\r?$//mg; $font->[$i] = [$length,#maxLen $wLead, #wLead
Subject: Re: [rt.cpan.org #56588] some TOIlet fonts displayed with a column of '@' at ther right border
Date: Wed, 14 Apr 2010 19:14:44 -0400
To: bug-Text-FIGlet [...] rt.cpan.org
From: Jerrad Pierce <belg4mit [...] pthbb.org>
Thanks for the bug report, unfortunately the patch in question is too specific with respect to end of character line marker. I'll look into relaxing the parser, but will have to run some tests to see if it is possible to solve this problem without introducing others. -- Free map of local environmental resources: http://CambridgeMA.GreenMap.org -- MOTD on Prickle-Prickle, the 31st of Discord, in the YOLD 3176: Too la roo la roo la roo la roooooooo!
RT-Send-CC: sam [...] zoy.org
Hello, Sorry for the great delay in getting back to you about this. I have found that the problem lies with the font files. Toilet fonts auto-generated by caca2tlf have spaces after the @ end-of line marker, when they should instead have a hardspace in front of them. e.g; double quotes in mono 9 should be: $@ ▄ ▄ $@ █ █ $@ $@ $@ $@ $@ @@ instead of the following (there are spaces after lone @s) @ ▄ ▄ @ █ █ @ @ @ @ @ @@ The corrected font file will render the same.