Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the XML-Stream CPAN distribution.

Report information
The Basics
Id: 56574
Status: resolved
Priority: 0/
Queue: XML-Stream
People
Owner: dapatrick [...] cpan.org
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.23
Fixed in: 1.23_02

History Show all quoted text
  Tue Apr 13 16:52:03 2010 TODDR [...] cpan.org - Ticket created
Subject: Test suite under perl 5.12 produces warnings
The test suite now looks like this. + make test PERL_DL_NONLAZY=1 /usr/local/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/0-signature.t .. skipped: Set the environment variable TEST_SIGNATURE to enable this test. Cannot resolve rpmb-centos-4-64bit: at lib/XML/Stream.pm line 409. # Looks like you planned 56 tests but ran 1. # Looks like your test exited with 255 just after 1. t/buildxml.t ..... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 55/56 subtests t/cdata.t ........ ok t/load.t ......... ok Cannot resolve rpmb-centos-4-64bit: at /home/user/tmp/XML-Stream- 1.23/blib/lib/XML/Stream.pm line 409. t/parse_node.t ... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 6/7 subtests Cannot resolve rpmb-centos-4-64bit: at /home/user/tmp/XML-Stream- 1.23/blib/lib/XML/Stream.pm line 409. t/parse_tree.t ... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/5 subtests Use of uninitialized value within @_ in lc at lib/XML/Stream/Parser.pm line 71. Use of uninitialized value within @_ in lc at lib/XML/Stream/Parser.pm line 71. t/quotes.t ....... ok Cannot resolve rpmb-centos-4-64bit: at /home/user/tmp/XML-Stream- 1.23/blib/lib/XML/Stream.pm line 409. # Looks like you planned 4 tests but only ran 1. # Looks like your test died just after 1. t/tcpip.t ........ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/4 subtests t/tcpip2ssl.t .... ok Use of uninitialized value within @_ in lc at /home/user/tmp/XML-Stream- 1.23/blib/lib/XML/Stream/Parser.pm line 71. Use of uninitialized value within @_ in lc at /home/user/tmp/XML-Stream- 1.23/blib/lib/XML/Stream/Parser.pm line 71. t/xml2config.t ... ok Use of uninitialized value within @_ in lc at /home/user/tmp/XML-Stream- 1.23/blib/lib/XML/Stream/Parser.pm line 71. Use of uninitialized value within @_ in lc at /home/user/tmp/XML-Stream- 1.23/blib/lib/XML/Stream/Parser.pm line 71. t/xpath.t ........ ok Test Summary Report ------------------- t/buildxml.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 56 tests but ran 1. t/parse_node.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 7 tests but ran 1. t/parse_tree.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 1. t/tcpip.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 4 tests but ran 1. Files=11, Tests=130, 2 wallclock secs ( 0.06 usr 0.06 sys + 0.83 cusr 0.21 csys = 1.16 CPU) Result: FAIL Failed 4/11 test programs. 0/130 subtests failed.
  Tue Apr 13 16:54:43 2010 TODDR [...] cpan.org - Correspondence added
This patch should prevent the warning on line 71, but I'm concerned why an odd number of parameters are being passed in. Note this warning was not present prior to perl 5.12 so the issue would not have been visible.
Subject: patch.txt
diff --git a/lib/XML/Stream/Parser.pm b/lib/XML/Stream/Parser.pm index a84484b..8174959 100644 --- a/lib/XML/Stream/Parser.pm +++ b/lib/XML/Stream/Parser.pm @@ -68,7 +68,7 @@ sub new bless($self); my %args; - while($#_ >= 0) { $args{ lc pop(@_) } = pop(@_); } + while(@_ > 1) { $args{ lc pop(@_) } = pop(@_); } $self->{PARSING} = 0; $self->{DOC} = 0;
  Tue Apr 13 16:54:44 2010 TODDR [...] cpan.org - Status changed from 'new' to 'open'
  Tue Apr 13 17:18:10 2010 TODDR [...] cpan.org - Correspondence added
This was happening in the code because the class name was not being pulled off of @_. so I guess $ARGS{undef} used to == the class name. Was this intentional? Looking at the code, I don't think so. An additional patch might be advisable to shift the class name off of @_ and bless using the class name:
Subject: patch.txt
diff --git a/lib/XML/Stream/Parser.pm b/lib/XML/Stream/Parser.pm index a84484b..022fd80 100644 --- a/lib/XML/Stream/Parser.pm +++ b/lib/XML/Stream/Parser.pm @@ -63,12 +63,10 @@ use XML::Stream::Node; sub new { - my $self = { }; - - bless($self); + my $self = bless({}, shift); my %args; - while($#_ >= 0) { $args{ lc pop(@_) } = pop(@_); } + while(@_ > 1) { $args{ lc pop(@_) } = pop(@_); } $self->{PARSING} = 0; $self->{DOC} = 0;
  Wed Sep 15 13:12:57 2010 dapatrick [...] cpan.org - Taken
  Fri Sep 17 16:28:45 2010 dapatrick [...] cpan.org - Correspondence added
Todd, Thanks for the report and patch. This is weird, because this passes most of the time, according to CPAN Testers: http://matrix.cpantesters.org/?dist=XML-Stream+1.23 Darian
  Fri Sep 17 16:32:49 2010 dapatrick [...] cpan.org - Correspondence added
I do see it failing with this error on previous versions as well. Weird.
  Fri Sep 17 17:03:10 2010 dapatrick [...] cpan.org - Correspondence added
I just perlbrewed 5.12.2 and I can reproduce the errors here, but the tests still pass. I'm fixing now.
  Fri Sep 17 17:13:45 2010 dapatrick [...] cpan.org - Correspondence added
Okay, this kind of makes more sense now. I only saw one pre-5.12 fail from CPAN Testers and that was a 5.11 build. I patched this and it's up on github now. Only the shift and corrected bless call were necessary. Thanks again, Darian
  Fri Sep 17 17:13:46 2010 dapatrick [...] cpan.org - Status changed from 'open' to 'patched'
  Mon Sep 20 15:29:39 2010 dapatrick [...] cpan.org - Fixed in 1.23_02 added
  Mon Dec 22 16:35:05 2014 dapatrick [...] cpan.org - Status changed from 'patched' to 'resolved'