Skip Menu |

This queue is for tickets about the Gitalist CPAN distribution.

Report information
The Basics
Id: 56386
Status: resolved
Priority: 0/
Queue: Gitalist
People
Owner: BROQ [...] cpan.org
Requestors: llap [...] cuckoo.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.000006_01
Fixed in: (no value)

History Show all quoted text
  Thu Apr 08 08:04:31 2010 llap [...] cuckoo.org - Ticket created
Subject: diff a/ b/ links do not always work (if file removed)
If the file has been removed then the when viewing the diff: diff --git a/... b/... The links do not work (as the file doesn't exist in the HEAD), so ideally they shouldn't be links Also, should these links actually go through to a <sha1> in which they are relevant (e.g. the 'a' sha1 and the 'b' sha1)? - then so in the above example a/... would be a link, but b/.. wouldn't be?
  Fri Apr 09 18:36:15 2010 BROQ [...] cpan.org - Taken
  Fri Apr 09 18:36:57 2010 BROQ [...] cpan.org - Correspondence added
On Thu Apr 08 08:04:31 2010, llap@cuckoo.org wrote: Show quoted text
> If the file has been removed then the when viewing the diff: > > diff --git a/... b/... > > The links do not work (as the file doesn't exist in the HEAD), so > ideally they > shouldn't be links > > Also, should these links actually go through to a <sha1> in which they > are > relevant (e.g. the 'a' sha1 and the 'b' sha1)? - then so in the above > example > a/... would be a link, but b/.. wouldn't be?
Now fixed in master as of: http://github.com/broquaint/Gitalist/commit/3a58f004e86fccfa384065e6da7d 268917afb1b8 -- Cheers, Dan Brook
  Fri Apr 09 18:36:58 2010 The RT System itself - Status changed from 'new' to 'open'
  Fri Apr 09 18:36:58 2010 BROQ [...] cpan.org - Status changed from 'open' to 'resolved'