Skip Menu |

This queue is for tickets about the Net-P0f CPAN distribution.

Report information
The Basics
Id: 56347
Status: open
Priority: 0/
Queue: Net-P0f

People
Owner: Nobody in particular
Requestors: david [...] cantrell.org.uk
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.02
Fixed in: (no value)



Subject: Missing pre-requisite, taint problems, other failing tests
You don't declare the pre-req on Test::Warn; There's possible taint problems with t/11findalldevs: $ sudo perl -Mblib t/11findalldevs.t "-T" is on the #! line, it must also be used on the command line at t/11findalldevs.t line 1. $ sudo perl -T -Mblib t/11findalldevs.t Insecure dependency in require while running with -T switch at t/11findalldevs.t line 3. BEGIN failed--compilation aborted at t/11findalldevs.t line 3. but they go away thus, only to expose a failing test: $ sudo perl -T -I blib/lib t/11findalldevs.t 1..5 not ok 1 # Failed test at t/11findalldevs.t line 22. ok 2 ok 3 ok 4 ok 5 $ perl -V|grep -i conf Summary of my perl5 (revision 5 version 10 subversion 0) configuration: config_args='-de -Dusethreads'
On 2010-04-07 06:48:23, DCANTRELL wrote: Show quoted text
> You don't declare the pre-req on Test::Warn;
Also undeclared: Test::Exception Show quoted text
> > There's possible taint problems with t/11findalldevs: > > $ sudo perl -Mblib t/11findalldevs.t > "-T" is on the #! line, it must also be used on the command line at > t/11findalldevs.t line 1. > $ sudo perl -T -Mblib t/11findalldevs.t > Insecure dependency in require while running with -T switch at > t/11findalldevs.t line 3. > BEGIN failed--compilation aborted at t/11findalldevs.t line 3. > > but they go away thus, only to expose a failing test: > > $ sudo perl -T -I blib/lib t/11findalldevs.t > 1..5 > not ok 1 > # Failed test at t/11findalldevs.t line 22. > ok 2 > ok 3 > ok 4 > ok 5 > > $ perl -V|grep -i conf > Summary of my perl5 (revision 5 version 10 subversion 0) configuration: > config_args='-de -Dusethreads'