Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Git-Wrapper CPAN distribution.

Report information
The Basics
Id: 56323
Status: resolved
Priority: 0/
Queue: Git-Wrapper
People
Owner: GENEHACK [...] cpan.org
Requestors: gam3-pause [...] gam3.net
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.008
Fixed in: (no value)

History Show all quoted text
  Tue Apr 06 12:03:44 2010 gam3-pause [...] gam3.net - Ticket created
If git command returns an error code but no error string then an If ($@) will fail because of the overloaded "" with return an empty string. It is not clear what should happen here: should "" return "Error:" or should the Exception not be thrown if there is no error string? I am seeing git-status return 256 with no error on Debian, which is why I am seeing this problem.
  Tue Apr 06 12:06:34 2010 gam3-pause [...] gam3.net - Subject changed from (no value) to 'Exceptions with not error output.'
  Tue Apr 06 12:07:04 2010 gam3-pause [...] gam3.net - Subject changed from 'Exceptions with not error output.' to 'Exceptions with no error output.'
  Tue Apr 06 12:08:52 2010 gam3-pause [...] gam3.net - Correspondence added
I am using 'if (ref($@) || $@)' as a work around for not.
  Tue Apr 06 12:08:53 2010 gam3-pause [...] gam3.net - Status changed from 'new' to 'open'
  Tue Apr 06 12:09:27 2010 gam3-pause [...] gam3.net - Status changed from 'open' to 'new'
  Fri Jul 08 22:19:06 2011 GENEHACK [...] cpan.org - Taken
  Fri Jul 08 23:26:37 2011 GENEHACK [...] cpan.org - Correspondence added
On Tue Apr 06 12:03:44 2010, GAM wrote: Show quoted text
> If git command returns an error code but no error string then an > If ($@) > will fail because of the overloaded "" with return an empty string. > > It is not clear what should happen here: should "" return "Error:" > or should the Exception not be thrown if there is no error string? > > I am seeing git-status return 256 with no error on Debian, which is why > I am seeing this problem.
What version of git is doing that? Are you still having this problem? Is using Try::Tiny an option for you? That generally makes exception catching much nicer. I do have an idea about how this could be fixed, but I think I need to think about it a bit more... thanks, john.
  Fri Jul 08 23:26:39 2011 The RT System itself - Status changed from 'new' to 'open'
  Tue Sep 13 07:40:56 2011 GENEHACK [...] cpan.org - Correspondence added
On Fri Jul 08 23:26:37 2011, GENEHACK wrote: Show quoted text
> On Tue Apr 06 12:03:44 2010, GAM wrote:
> > If git command returns an error code but no error string then an > > If ($@) > > will fail because of the overloaded "" with return an empty string. > > > > It is not clear what should happen here: should "" return "Error:" > > or should the Exception not be thrown if there is no error string? > > > > I am seeing git-status return 256 with no error on Debian, which is
> why
> > I am seeing this problem.
> > What version of git is doing that? Are you still having this problem? > > Is using Try::Tiny an option for you? That generally makes exception > catching much nicer. > > I do have an idea about how this could be fixed, but I think I need to > think about it a bit > more...
If you could answer my questions above, it would be helpful in figuring out how to resolve this issue. thanks, john.
  Sun Apr 22 13:41:19 2012 GENEHACK [...] cpan.org - Correspondence added
On Tue Sep 13 07:40:56 2011, GENEHACK wrote: Show quoted text
> On Fri Jul 08 23:26:37 2011, GENEHACK wrote:
> > On Tue Apr 06 12:03:44 2010, GAM wrote:
> > > If git command returns an error code but no error string then an > > > If ($@) > > > will fail because of the overloaded "" with return an empty
> string.
> > > > > > It is not clear what should happen here: should "" return "Error:" > > > or should the Exception not be thrown if there is no error string? > > > > > > I am seeing git-status return 256 with no error on Debian, which
> is
> > why
> > > I am seeing this problem.
> > > > What version of git is doing that? Are you still having this
> problem?
> > > > Is using Try::Tiny an option for you? That generally makes exception > > catching much nicer. > > > > I do have an idea about how this could be fixed, but I think I need
> to
> > think about it a bit > > more...
> > If you could answer my questions above, it would be helpful in > figuring out how to > resolve this issue. > > thanks, > john.
Closing due to lack of response. Underlying issue is going to be addressed in other tickets.
  Sun Apr 22 13:41:21 2012 GENEHACK [...] cpan.org - Status changed from 'open' to 'resolved'