Skip Menu |

This queue is for tickets about the IO-Socket-Multicast CPAN distribution.

Report information
The Basics
Id: 56319
Status: open
Priority: 0/
Queue: IO-Socket-Multicast

People
Owner: Nobody in particular
Requestors: chris [...] computersalat.de
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.11
Fixed in: (no value)



Subject: fix testsuite
Hi, when building package in buildservice (openSUSE Build Service), testsuite fails cause of not having an interface. Attached patch provides a fix. hoping you agree or improve my fix :) Kind Regards Chris
Subject: IO-Socket-Multicast-t_03.patch
diff -ruN IO-Socket-Multicast-1.11-orig/t/03_multicast.t IO-Socket-Multicast-1.11/t/03_multicast.t --- IO-Socket-Multicast-1.11-orig/t/03_multicast.t 2009-11-03 22:42:32.000000000 +0000 +++ IO-Socket-Multicast-1.11/t/03_multicast.t 2010-04-06 12:50:15.980191043 +0000 @@ -25,10 +25,13 @@ my $INTERFACE = $IO_INTERFACE && find_a_mcast_if($s); -isa_ok( $s, 'IO::Socket::Multicast' ); - -ok($s->mcast_add($MCAST_ADDR), 'Add socket to Multicast Group' ); -ok($s->mcast_drop($MCAST_ADDR),'Drop Multicast Group' ); +SKIP: { + # run only if there is an interface + skip("There is no interface, so we can't check", 3) unless $INTERFACE; + isa_ok( $s, 'IO::Socket::Multicast' ); + ok($s->mcast_add($MCAST_ADDR), 'Add socket to Multicast Group' ); + ok($s->mcast_drop($MCAST_ADDR),'Drop Multicast Group' ); +} # Some basics SKIP: {
I agree - I believe 1.12 has many changes to the tests resolving this and other issues. If possible can you please try that release to see if it builds correctly.
Subject: Re: [rt.cpan.org #56319] fix testsuite
Date: Wed, 07 Apr 2010 13:21:08 +0000
To: bug-IO-Socket-Multicast [...] rt.cpan.org
From: Christian <chris [...] computersalat.de>
Hi Andrew, would you tell me where to get 1.12. Can not find it on cpan. Andrew Bramble via RT schrieb: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=56319 > > > I agree - I believe 1.12 has many changes to the tests resolving this > and other issues. If possible can you please try that release to see if > it builds correctly. > >
Bizarre - I was sure that had been released! Sorry . You can try http://svn.perlide.org/padre/trunk/IO-Socket-Multicast in the interim. On Wed Apr 07 09:22:51 2010, chris@computersalat.de wrote: Show quoted text
> Hi Andrew, > > would you tell me where to get 1.12. > Can not find it on cpan. > > Andrew Bramble via RT schrieb:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=56319 > > > > > I agree - I believe 1.12 has many changes to the tests resolving this > > and other issues. If possible can you please try that release to see if > > it builds correctly. > > > >
From: Christian
Hi Andrew, it doesn't work :( cause there is no difference of testsuite to 1.11. t/03_multicast.... # Failed test 'Add socket to Multicast Group' # at t/03_multicast.t line 30. # Failed test 'Drop Multicast Group' # at t/03_multicast.t line 31. # Looks like you failed 2 tests of 14. with my patch it works. If there is no interface then tests are skipped. Chris
I misread this bug. You mean if there is no real interface (eth0/etc) not if IO::Interface is available. Applied r11307 Do you want crediting in changes file? On Fri Apr 09 06:25:05 2010, http://jimmi.pip.verisignlabs.com/ wrote: Show quoted text
> Hi Andrew, > > it doesn't work :( > cause there is no difference of testsuite to 1.11. > > t/03_multicast.... > # Failed test 'Add socket to Multicast Group' > # at t/03_multicast.t line 30. > > # Failed test 'Drop Multicast Group' > # at t/03_multicast.t line 31. > # Looks like you failed 2 tests of 14. > > with my patch it works. > If there is no interface then tests are skipped. > > Chris
Am Fr 09. Apr 2010, 21:41:09, bramble schrieb: Show quoted text
> I misread this bug. You mean if there is no real interface (eth0/etc) > not if IO::Interface is available. > Applied r11307 > > Do you want crediting in changes file?
yes, please :) Christian W. <chris (at) computersalat (dot) de>