Bug #56170 for CGI-Expand: Example broken w/o import: print CGI::Expand::expand

Wed Mar 31 13:35:34 2010 MJD [...] cpan.org - Ticket created

% perl -MCGI::Expand= -le 'print CGI::Expand::expand_hash({ "a.0" => 77 })' Can't call method "separator" on unblessed reference at /usr/pkg/lib/perl5/site_perl/5.8.0/CGI/Expand.pm line 100. That's the example from the manual.

Wed Mar 31 13:55:46 2010 rjbs [...] cpan.org - Correspondence added

On 2010-03-31 13:35:34, MJD wrote: Show quoted text

> % perl -MCGI::Expand= -le 'print CGI::Expand::expand_hash({ "a.0" => 77 })' > > Can't call method "separator" on unblessed reference at > /usr/pkg/lib/perl5/site_perl/5.8.0/CGI/Expand.pm line 100. > > That's the example from the manual.

The problem is that the documentation is insufficiently clear about the fact that the expand_* methods must be imported to work. They should be documented as methods, with the curried exports explained separately, to dissolve expectations that the routines can be called directly. If you have a git repo somewhere I can send you commits. I think this could also be easily tweaked to allow subclassing-free special separators, etc. -- rjbs

Wed Mar 31 13:55:49 2010 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 05 23:22:01 2010 perl-cpan [...] bereft.net - Cc RJBS added

Mon Apr 05 23:22:34 2010 perl-cpan [...] bereft.net - Given to BOWMANBS

Mon Apr 05 23:27:26 2010 perl-cpan [...] bereft.net - Subject changed from (no value) to 'Example broken w/o import: print CGI::Expand::expand_hash({ "a.0" => 77 })'

Mon Apr 05 23:27:26 2010 perl-cpan [...] bereft.net - Severity Important changed to Normal

Mon Apr 05 23:28:58 2010 perl-cpan [...] bereft.net - Correspondence added

On Wed Mar 31 13:55:46 2010, RJBS wrote: Show quoted text

> On 2010-03-31 13:35:34, MJD wrote:

> > % perl -MCGI::Expand= -le 'print CGI::Expand::expand_hash({ "a.0" =>

> 77 })'

> > > > Can't call method "separator" on unblessed reference at > > /usr/pkg/lib/perl5/site_perl/5.8.0/CGI/Expand.pm line 100. > > > > That's the example from the manual.

Thanks for the report. I must have broken the example during the 1.03 to 2.* transition. Show quoted text

> The problem is that the documentation is insufficiently clear about > the fact that the expand_* > methods must be imported to work. They should be documented as > methods, with the > curried exports explained separately, to dissolve expectations that > the routines can be called > directly. > > If you have a git repo somewhere I can send you commits. I think this > could also be easily > tweaked to allow subclassing-free special separators, etc.

I've been intending to put my modules on github for a while now. I'll do so this week and let you know the url. Thanks for the help, Brad

Tue Jul 06 23:06:33 2010 perl-cpan [...] bereft.net - Correspondence added

On Wed Mar 31 13:55:46 2010, RJBS wrote: Show quoted text

> On 2010-03-31 13:35:34, MJD wrote:

> > % perl -MCGI::Expand= -le 'print CGI::Expand::expand_hash({ "a.0" =>

> 77 })'

> > > > Can't call method "separator" on unblessed reference at > > /usr/pkg/lib/perl5/site_perl/5.8.0/CGI/Expand.pm line 100. > > > > That's the example from the manual.

> > The problem is that the documentation is insufficiently clear about > the fact that the expand_* > methods must be imported to work. They should be documented as > methods, with the > curried exports explained separately, to dissolve expectations that > the routines can be called > directly. > > If you have a git repo somewhere I can send you commits. > I think this could also be easily > tweaked to allow subclassing-free special separators, etc.

Sorry for the delay, RSI. I have setup a github repo for CGI::Expand and would appreciate a patch (Ricardo): http://github.com/bowman/CGI-Expand Thanks, Brad Bowman

Thu Mar 24 22:10:52 2011 rjbs [...] cpan.org - Correspondence added

Shockingly, I have also finally gotten back to this: https://github.com/rjbs/CGI-Expand I've clarified the method / function thing a bit and tweaked the use of C<> blocks in =item, which had made it hard to link to specific items with L<>. -- rjbs

Thu Mar 24 22:43:39 2011 perl-cpan [...] bereft.net - Correspondence added

RJBS's patch applied and released as 2.03. Thank you both.

Thu Mar 24 22:43:39 2011 perl-cpan [...] bereft.net - Status changed from 'open' to 'resolved'

Bug #56170 for CGI-Expand: Example broken w/o import: print CGI::Expand::expand_hash({ "a.0" => 77 })