Bug #56109 for Test-CheckChanges: Multiple plans in t\multi.t test.

Tue Mar 30 11:25:14 2010 csjewell [...] cpan.org - Ticket created

Subject:

Multiple plans in t\multi.t test.

In t\multi.t: our $name = File::Spec->catdir('t', 'bad', 'multiple', 'CHANGES'); if (-e $name) { plan skip_all => "case insensitive filesystem"; } Maybe you need an exit(0) in there, because it's not exiting... Test Summary Report ------------------- t\multi.t (Wstat: 0 Tests: 0 Failed: 0) Parse errors: More than one plan found in TAP output Files=26, Tests=37, 3 wallclock secs ( 0.28 usr + 0.11 sys = 0.39 CPU) Result: FAIL Failed 1/26 test programs. 0/37 subtests failed. C:/Users/Curtis/Desktop/Test-CheckChanges-0.14/. C:\strawberry\perl\bin\perl.exe ./Build test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports C:/Users/Curtis/Desktop/Test-CheckChanges-0.14/. Running Build install make test had returned bad status, won't install without force C:\Users\Curtis\Desktop\Test-CheckChanges-0.14>perl -Mblib t\multi.t 1..0 # SKIP case insensitive filesystem 1..2

Tue Apr 06 12:11:07 2010 gam3-pause [...] gam3.net - Status changed from 'new' to 'open'

Tue Apr 06 12:11:08 2010 gam3-pause [...] gam3.net - Given to GAM

Sun Apr 01 07:52:36 2012 CHORNY [...] cpan.org - Correspondence added

On Tue Mar 30 11:25:14 2010, CSJEWELL wrote: Show quoted text

> In t\multi.t: > > our $name = File::Spec->catdir('t', 'bad', 'multiple', 'CHANGES'); > if (-e $name) { > plan skip_all => "case insensitive filesystem"; > } > > Maybe you need an exit(0) in there, because it's not exiting...

And that is not Test::More problem. This tests exits correctly after "plan skip_all". use strict; use warnings; use Test::More; plan skip_all => "case insensitive filesystem"; print 'still works'; -- Alexandr Ciornii, http://chorny.net

Sun Apr 01 07:52:56 2012 CHORNY [...] cpan.org - Requestor CHORNY added

Wed Jul 25 04:00:01 2012 dmacks [...] netspace.org - Correspondence added

Subject:	[rt.cpan.org #56109]
Date:	Wed, 25 Jul 2012 03:59:42 -0400
To:	bug-test-checkchanges [...] rt.cpan.org
From:	"Daniel Macks" <dmacks [...] netspace.org>

The second plan appears to be generated by the Dummy::done_testing() function. It appears that $Test::CheckChanges::test = bless {}, 'Dummy'; causes that function to be run immediately (automatically running an initializer without explicitly calling new() or other function seems needlessly surprising behavior!). Deferring doing that setup until after deciding whether to skip (see attached patch) resolves the problem for me (case-insensitive OS X) because that makes Dummy::done_testing() only generate a plan if we're *not* generating the plan to skip. dan -- Daniel Macks dmacks@netspace.org

Message body is not shown because sender requested not to inline it.

Sat Aug 03 11:36:53 2013 ether [...] cpan.org - Correspondence added

On 2012-07-25 01:00:01, dmacks@netspace.org wrote: Show quoted text

> The second plan appears to be generated by the Dummy::done_testing() > function. It appears that > > $Test::CheckChanges::test = bless {}, 'Dummy'; > > causes that function to be run immediately (automatically running an > initializer without explicitly calling new() or other function seems > needlessly surprising behavior!). Deferring doing that setup until > after deciding whether to skip (see attached patch) resolves the > problem for me (case-insensitive OS X) because that makes > Dummy::done_testing() only generate a plan if we're *not* generating > the plan to skip. > > dan > > -- > Daniel Macks > dmacks@netspace.org

This module shouldn't be generating a plan at all. It's up to the caller to call done_testing, himself, after finishing with ok_changes() or whatever.