Skip Menu |

This queue is for tickets about the Crypt-SMIME CPAN distribution.

Report information
The Basics
Id: 56025
Status: resolved
Priority: 0/
Queue: Crypt-SMIME
People
Owner: mikage [...] ymir.co.jp
Requestors: jkeen [...] verizon.net
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.09
Fixed in: (no value)

History Show all quoted text
  Sun Mar 28 11:30:08 2010 jkeen [...] verizon.net - Ticket created
Subject: 'make clean' removes source code file SMIME.pod
In CPAN distributions that use ExtUtils::MakeMaker, the command 'make clean' is generally used to delete those files created during 'perl Makefile.PL' and 'make' -- but *only* those files. However, as the following sequence of commands indicates, 'make clean' in Crypt-SMIME in effect does too much, viz., it removes source code file 'SMIME.pod'. This means that if you call 'perl Makefile.PL' after having called 'make clean', 'SMIME.pod' is reported as missing and a second attempt at building will fail. [Crypt-SMIME-0.09] 662 $ perl Makefile.PL Writing Makefile for Crypt::SMIME [Crypt-SMIME-0.09] 663 $ make cp lib/SMIME/JA.pod blib/lib/Crypt/SMIME/JA.pod cp lib/SMIME.pm blib/lib/Crypt/SMIME.pm /usr/local/bin/perl /usr/local/lib/perl5/5.10.1/ExtUtils/xsubpp -typemap /usr/local/lib/perl5/5.10.1/ExtUtils/typemap -typemap typemap SMIME.xs > SMIME.xsc && mv SMIME.xsc SMIME.c cc -c -fno-common -DPERL_DARWIN -no-cpp-precomp -fno-strict-aliasing -pipe -I/usr/local/include -I/opt/local/include -O3 -DVERSION=\"0.09\" -DXS_VERSION=\"0.09\" "-I/usr/local/lib/perl5/5.10.1/darwin-2level/CORE" SMIME.c Running Mkbootstrap for Crypt::SMIME () chmod 644 SMIME.bs rm -f blib/arch/auto/Crypt/SMIME/SMIME.bundle LD_RUN_PATH="/opt/local/lib" env MACOSX_DEPLOYMENT_TARGET=10.3 cc -bundle -undefined dynamic_lookup -L/usr/local/lib -L/opt/local/lib SMIME.o -o blib/arch/auto/Crypt/SMIME/SMIME.bundle \ -lcrypto \ chmod 755 blib/arch/auto/Crypt/SMIME/SMIME.bundle cp SMIME.bs blib/arch/auto/Crypt/SMIME/SMIME.bs chmod 644 blib/arch/auto/Crypt/SMIME/SMIME.bs Manifying blib/man3/SMIME::JA.3 Manifying blib/man3/SMIME.3 [Crypt-SMIME-0.09] 664 $ make clean rm -f \ *.a core \ core.[0-9] blib/arch/auto/Crypt/SMIME/extralibs.all \ core.[0-9][0-9] SMIME.bso \ pm_to_blib.ts SMIME.c \ core.[0-9][0-9][0-9][0-9] SMIME.x \ SMIME.bs perl \ tmon.out *.o \ pm_to_blib blib/arch/auto/Crypt/SMIME/extralibs.ld \ blibdirs.ts core.[0-9][0-9][0-9][0-9][0-9] \ *perl.core core.*perl.*.? \ Makefile.aperl perl \ SMIME.def core.[0-9][0-9][0-9] \ mon.out libSMIME.def \ perlmain.c perl.exe \ so_locations SMIME.exp rm -rf \ Crypt-SMIME-* SMIME.pod \ blib mv Makefile Makefile.old > /dev/null 2>&1 [Crypt-SMIME-0.09] 665 $ perl Makefile.PL Checking if your kit is complete... Warning: the following files are missing in your kit: SMIME.pod Please inform the author. Writing Makefile for Crypt::SMIME [Crypt-SMIME-0.09] 666 $ ll *.pod ls: *.pod: No such file or directory This patch to Makefile.PL should fix the problem: - FILES => 'Crypt-SMIME-* SMIME.pod', + FILES => 'Crypt-SMIME-*', Thank you very much. Jim Keenan
  Fri Sep 09 07:00:08 2011 fschlich [...] zedat.fu-berlin.de - Correspondence added
From: fschlich [...] zedat.fu-berlin.de
Hi, another possibility would be to make full use of the dependencies already specified in Makefile.PL, by adding a build requirement on Pod::MultiLang and then both deleting and remaking all of SMIME.pod, lib/SMIME.pm and lib/SMIME/JA.pod, perhaps like so: --- a/Makefile.PL +++ b/Makefile.PL @@ -12,15 +12,18 @@ ABSTRACT => 'S/MIME message signing, verification, encryption and decryption', PL_FILES => {}, PREREQ_PM => { - 'Test::Exception' => 0, - 'Test::More' => 0, 'XSLoader' => 0, }, + BUILD_REQUIRES => { + 'Test::Exception' => 0, + 'Test::More' => 0, + 'Pod::MultiLang' => 0, + }, LIBS => "$OPENSSL->{LIBS}", INC => "$OPENSSL->{CFLAGS}", dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', }, clean => { - FILES => 'Crypt-SMIME-* SMIME.pod', + FILES => 'Crypt-SMIME-* SMIME.pod lib/', }, PM => { 'lib/SMIME.pm' => '$(INST_LIBDIR)/SMIME.pm', --- a/MANIFEST +++ b/MANIFEST @@ -1,6 +1,4 @@ Changes -lib/SMIME.pm -lib/SMIME/JA.pod Makefile.PL MANIFEST This list of files MANIFEST.SKIP @@ -8,7 +6,6 @@ README SMIME.mlpod SMIME.pl -SMIME.pod SMIME.xs t/chained-certs.t t/smime.more.t (deletion of SMIME.pod, lib/SMIME.pm and lib/SMIME/JA.pod omitted from patch for brevity). Florian
  Fri Sep 09 07:00:10 2011 The RT System itself - Status changed from 'new' to 'open'
  Fri Sep 09 10:10:10 2011 jkeenan [...] cpan.org - Correspondence added
On Fri Sep 09 07:00:08 2011, fschlich wrote: Show quoted text
> Hi, > > another possibility would be to make full use of the dependencies > already specified in Makefile.PL,
I note that author MIKAGE issued a new version 0.10 of this distribution on 20 Apr 2011 but failed to correct the bug over a year earlier on 28 Mar 2010. Jim Keenan
  Fri May 02 00:54:26 2014 mikage [...] ymir.co.jp - Correspondence added
Fixed in 0.11. Thank you for your report.
  Fri May 02 00:54:27 2014 mikage [...] ymir.co.jp - Status changed from 'open' to 'resolved'
  Fri May 02 00:54:27 2014 mikage [...] ymir.co.jp - Taken