Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Business-ISBN-Data CPAN distribution.

Report information
The Basics
Id: 55991
Status: resolved
Priority: 0/
Queue: Business-ISBN-Data

People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 20081208
Fixed in: (no value)



Subject: test suite uses deprecated 'defined %hash'
check_data_structure.t uses a defined check on a hash. This is deprecated in 5.11. Removing the defined should work just as well. Patch attached for fix.
Subject: patch.txt
diff --git a/t/check_data_structure.t b/t/check_data_structure.t index 096cbd8..4e6970b 100644 --- a/t/check_data_structure.t +++ b/t/check_data_structure.t @@ -3,7 +3,7 @@ use Test::More 'no_plan'; use_ok( 'Business::ISBN::Data' ); -ok( defined %Business::ISBN::country_data ); +ok( %Business::ISBN::country_data ); foreach my $key ( sort { $a <=> $b } keys %Business::ISBN::country_data ) { @@ -15,4 +15,4 @@ foreach my $key ( sort { $a <=> $b } keys %Business::ISBN::country_data ) my $count = @$ranges; ok( ($count % 2) == 0, "Even number of elements ($count) for country $key" ); - } \ No newline at end of file + }
On Sat Mar 27 01:07:32 2010, TODDR wrote: Show quoted text
> check_data_structure.t uses a defined check on a hash. This is deprecated > in 5.11. Removing the defined should work just as well.
I've fixed this in the repository and it will be part of the next release.