Bug #55970 for Gitalist: Diffs on files..

Fri Mar 26 07:23:42 2010 llap [...] cuckoo.org - Ticket created

Subject:

Diffs on files..

On the Gitalist repo: /Gitalist/6806ac0d33d4d7e1e89ea022a78883cb2397e934/diff Then click on the diff icon next to the file.. /Gitalist/6806ac0d33d4d7e1e89ea022a78883cb2397e934/diff/lib/Gita list/Controller/LegacyURI.pm#diff1 and there is no diff? Ideally it should just scroll down, but because that snippet is used in several places it doesn't work - this goes back to confusing setup. It should also be possible to merge most commit and commitdiff pages (defaulting to always showing the diff).

Sun Mar 28 16:32:21 2010 BROQ [...] cpan.org - Correspondence added

On Fri Mar 26 07:23:42 2010, llap@cuckoo.org wrote: Show quoted text

> On the Gitalist repo: > > /Gitalist/6806ac0d33d4d7e1e89ea022a78883cb2397e934/diff > > Then click on the diff icon next to the file.. > > /Gitalist/6806ac0d33d4d7e1e89ea022a78883cb2397e934/diff/lib/Gita > list/Controller/LegacyURI.pm#diff1 > > and there is no diff?

Fixed! This was a problem with the rather delicate diff code. http://github.com/broquaint/Gitalist/commit/cbcd8397 Show quoted text

> Ideally it should just scroll down, but because that snippet is used

in Show quoted text

> several places it doesn't work - this goes back to confusing setup.

Now the action button goes to the individual file diff and the filenames have links which scroll to the appropriate point in the diff. Show quoted text

> It should also be possible to merge most commit and commitdiff pages > (defaulting to always showing the diff).

That could and should be done. -- Cheers, Dan Brook

Sun Mar 28 16:32:24 2010 The RT System itself - Status changed from 'new' to 'open'

Sun Mar 28 16:32:24 2010 BROQ [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Mar 28 16:32:25 2010 BROQ [...] cpan.org - Given to BROQ