Bug #55953 for Fuse: readdir isn't implemented

Fri Mar 26 01:45:34 2010 CYGA [...] cpan.org - Ticket created

Subject:

readdir isn't implemented

readdir isn't implemented I saw: --snip #if 0 /* * This doesn't yet work... we alwas get ENOSYS when trying to use readdir(). * Well, of course, getdir() is fine as well. */ int _PLfuse_readdir(const char *file, void *dirh, fuse_fill_dir_t dirfil, off_t off, struct fuse_file_info *fi) { #endif --snap But it's a big problem: while reading huge directory perl will "eat" a lot of memory for data structures used to store all directory entries & it won't return it to the system after :( I checked changelog at fuse project wiki: http://sourceforge.net/apps/mediawiki/fuse/index.php?title=ApiChangelog --snip API 23: ... - getdir is deprecated in favor of readdir --snap May be, we can implement it now? I can try to add such a code, but I'm not an experienced XS coder. Please clarify situation.

Thu Feb 24 11:51:31 2011 daniel.frett [...] ccci.org - Correspondence added

From:

daniel.frett [...] ccci.org

On Fri Mar 26 01:45:34 2010, CYGA wrote: Show quoted text

> readdir isn't implemented > > I saw: > --snip > #if 0 > /* > * This doesn't yet work... we alwas get ENOSYS when trying to use > readdir(). > * Well, of course, getdir() is fine as well. > */ > int _PLfuse_readdir(const char *file, void *dirh, fuse_fill_dir_t > dirfil, off_t off, struct fuse_file_info *fi) { > #endif > --snap > > But it's a big problem: > while reading huge directory perl will "eat" a lot of memory for data > structures used to store all directory entries & it > won't return it to the system after :( > > I checked changelog at fuse project wiki: > http://sourceforge.net/apps/mediawiki/fuse/index.php?title=ApiChangelog > --snip > API 23: > ... > - getdir is deprecated in favor of readdir > --snap > May be, we can implement it now? > I can try to add such a code, but I'm not an experienced XS coder. > > Please clarify situation.

I'm taking a guess that readdir doesn't work because FUSE_USE_VERSION isn't being defined, so fuse defaults to API level 21, which is before readdir was supported.

Thu Feb 24 11:51:32 2011 The RT System itself - Status changed from 'new' to 'open'

Thu Feb 24 13:10:38 2011 CYGA [...] cpan.org - Correspondence added

inline On Thu Feb 24 11:51:31 2011, dfrett wrote: Show quoted text

> On Fri Mar 26 01:45:34 2010, CYGA wrote:

> > readdir isn't implemented > > > > I saw: > > --snip > > #if 0 > > /* > > * This doesn't yet work... we alwas get ENOSYS when trying to use > > readdir(). > > * Well, of course, getdir() is fine as well. > > */ > > int _PLfuse_readdir(const char *file, void *dirh, fuse_fill_dir_t > > dirfil, off_t off, struct fuse_file_info *fi) { > > #endif > > --snap > > > > But it's a big problem: > > while reading huge directory perl will "eat" a lot of memory for

> data

> > structures used to store all directory entries & it > > won't return it to the system after :( > > > > I checked changelog at fuse project wiki: > >

> http://sourceforge.net/apps/mediawiki/fuse/index.php?title=ApiChangelog

> > --snip > > API 23: > > ... > > - getdir is deprecated in favor of readdir > > --snap > > May be, we can implement it now? > > I can try to add such a code, but I'm not an experienced XS coder. > > > > Please clarify situation.

> > I'm taking a guess that readdir doesn't work because FUSE_USE_VERSION > isn't being defined, > so fuse defaults to API level 21, which is before readdir was > supported.

No. There is no readdir neither in Fuse.pm nor in Fuse.xs. It was commented in Fuse.xs and mentioned in Fuse.pm. But wasn't implemented. I added simple wrap for it. Patch is attached. It would be nice if somebody will check it's xs code and apply it to mainstream. I used such patched solution for about half an year already.

Subject:

readdir.patch.gz

Download readdir.patch.gz
application/x-gzip 2.7k

Message body not shown because it is not plain text.

Thu Feb 24 17:13:26 2011 DPAVLIN [...] cpan.org - Taken

Thu Feb 24 17:13:59 2011 DPAVLIN [...] cpan.org - Broken in 0.09 added

Thu Feb 24 17:27:39 2011 DPAVLIN [...] cpan.org - Correspondence added

Thanks. I commited your changes in branch on github https://github.com/dpavlin/perl-fuse/tree/rt-55953-readdir which is based off version 0.09. It still needs few changes to be in sync with threading changes in current master. Unfortunately I won't be able to give this a try, at least for another week.

Thu Feb 24 23:59:38 2011 daniel.frett [...] ccci.org - Correspondence added

From:

daniel.frett [...] ccci.org

On Thu Feb 24 17:27:39 2011, DPAVLIN wrote: Show quoted text

> Thanks. I commited your changes in branch on github > > https://github.com/dpavlin/perl-fuse/tree/rt-55953-readdir > > which is based off version 0.09. It still needs few changes to be in > sync with threading changes in current master. > > Unfortunately I won't be able to give this a try, at least for another week.

I merged the current master with it and addressed the threading changes for the callback, I pushed the merge up to a branch on github. it compiles and runs the built-in test suite fine, but I didn't try the readdir example to make sure the new callbacks are truly working.

Sat Feb 26 05:54:29 2011 DPAVLIN [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Feb 26 05:54:29 2011 DPAVLIN [...] cpan.org - Fixed in 0.11 added