Bug #55901 for IO-Socket-INET6: perl 5.12.RC0::Socket causes warnings

Looking at possible fixes, I think the best thing would be to remove "inet_ntop inet_pton" from the use Socket6 statement and then explicitly call out to Socket6::inet_pton whenever it's needed. The alternative is to do crazy if conditions in a begin block to control what gets imported, depending on what version of perl is running. Patch attached:

diff --git a/lib/IO/Socket/INET6.pm b/lib/IO/Socket/INET6.pm index 89f44d6..57c5298 100644 --- a/lib/IO/Socket/INET6.pm +++ b/lib/IO/Socket/INET6.pm @@ -18,7 +18,7 @@ use Socket; # IO::Socket and Socket already import stuff here - possibly AF_INET6 # and PF_INET6 so selectively import things from Socket6. use Socket6 ( - qw(AI_PASSIVE inet_ntop inet_pton getaddrinfo + qw(AI_PASSIVE getaddrinfo sockaddr_in6 unpack_sockaddr_in6_all pack_sockaddr_in6_all) ); @@ -55,7 +55,7 @@ sub _sock_info { my @serv = (); if (defined $addr) { - if (!inet_pton(AF_INET6,$addr)) { + if (!Socket6::inet_pton(AF_INET6,$addr)) { if($addr =~ s,^\[([\da-fA-F:]+)\]:([\w\(\)/]+)$,$1,) { $port = $2; } elsif($addr =~ s,^\[(::[\da-fA-F.:]+)\]:([\w\(\)/]+)$,$1,) { @@ -383,7 +383,7 @@ sub sockhost { @_ == 1 or croak 'usage: $sock->sockhost()'; my ($sock) = @_; return undef unless (my $addr = $sock->sockaddr); - inet_ntop($sock->sockdomain, $addr); + Socket6::inet_ntop($sock->sockdomain, $addr); } sub sockflow @@ -420,7 +420,7 @@ sub peerhost { @_ == 1 or croak 'usage: $sock->peerhost()'; my ($sock) = @_; return undef unless (my $addr = $sock->peeraddr); - inet_ntop($sock->sockdomain, $addr); + Socket6::inet_ntop($sock->sockdomain, $addr); } sub peerflow @@ -561,7 +561,7 @@ Suppose either you have no IPv6 connectivity or www.perl.org has no http service $sock = IO::Socket::INET6->new('[::1]:25'); $sock = IO::Socket::INET6->new(PeerPort => 9999, - PeerAddr => inet_ntop(AF_INET6,in6addr_broadcast), + PeerAddr => Socket6::inet_ntop(AF_INET6,in6addr_broadcast), Proto => udp, LocalAddr => 'localhost', Broadcast => 1 )