Bug #55840 for Dist-Zilla-Plugin-ModuleInstall: generated "requires" list is rubbish

Tue Mar 23 10:48:26 2010 sjn [...] cpan.org - Ticket created

Subject:

generated "requires" list is rubbish

The generated Makefile.PL I have kools like this: ============================================ use strict; use warnings; use inc::Module::Install 0.95; name 'Kaizendo' ; abstract "A\ tool\ for\ collaborative\ authoring\ of\ polyscopic\ documents" ; author "Salve\ J\.\ Nilsen\ \<sjn\@kaizendo\.org\>"; version "1\.100820"; license ''; requires "_guts" => "HASH$0x99d2f78$"; requires "is_finalized" => "1"; WriteAll(); ======================================= First, the version number is rubbish (it's supposed to be "0.01") Second, the escaping is pointless. Third, and most seriousslu the requires list is completely whacked. Fix, please? This needs a quick release too, since your module is completely pointless now (and with RJBS creating buzz about Dist::Zilla, you'll get some attention too with your broken module!!) - Salve

Tue Mar 23 10:50:45 2010 sjn [...] cpan.org - Correspondence added

On Tue 23. mar. 2010 10:48:26, sjn wrote: Show quoted text

> The generated Makefile.PL I have kools like this:

It's generated with this dist.ini file: ============================================== name = Kaizendo author = Salve J. Nilsen <sjn@kaizendo.org> license = AGPL_3 copyright_holder = Salve J. Nilsen [AllFiles] [ModuleInstall] [PruneCruft] [License] [ExtraTests] [CriticTests] [PodTests] [AutoVersion] [AutoPrereq] [@Git] ==================================================

Tue Mar 23 10:50:46 2010 sjn [...] cpan.org - Status changed from 'new' to 'open'

Tue Mar 23 19:31:29 2010 cjm [...] cpan.org - Correspondence added

Well, the version number is your fault. Dzil is just doing what you told it to do. [AutoVersion] means to make up a version number for the dist based on the current date. (.100820 breaks down as 10 082 0, or (going backwards) release 0 on the 82nd day of 2010). Maybe you meant to use [VersionFromModule] instead? The "requires" issue is because the ModuleInstall plugin needs to be fixed to work with the current Dist::Zilla release. (Dist::Zilla is still quite young, and things change, sometimes incompatibly.)

Wed Mar 24 13:26:45 2010 sjn [...] pvv.org - Correspondence added

CC:	sjn [...] cpan.org
Subject:	Re: [rt.cpan.org #55840] generated "requires" list is rubbish
Date:	Wed, 24 Mar 2010 18:26:32 +0100 (CET)
To:	"Christopher J. Madsen via RT" <bug-Dist-Zilla-Plugin-ModuleInstall [...] rt.cpan.org>
From:	Salve J Nilsen <sjn [...] pvv.org>

Christopher J. Madsen via RT said: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=55840 > > > Maybe you meant to use [VersionFromModule] instead?

Yes, sorry about that. Mea culpa. Show quoted text

> The "requires" issue is because the ModuleInstall plugin needs to be > fixed to work with the current Dist::Zilla release. (Dist::Zilla is > still quite young, and things change, sometimes incompatibly.)

Ok. I'm still very new to Dist::Zilla, so I'm not sure I can offer useful patches to you. Any chances for an update despite this? (Maybe after a quick reality chech with rjbs? :) - Salve -- #!/usr/bin/perl sub AUTOLOAD{$AUTOLOAD=~/.*::(\d+)/;seek(DATA,$1,0);print# Salve Joshua Nilsen getc DATA}$"="'};&{'";@_=unpack("C*",unpack("u*",':4@,$'.# <sjn@foo.no> '2!--"5-(50P%$PL,!0X354UC-PP%/0\`'."\n"));eval "&{'@_'}"; __END__ is near! :)

Mon Apr 19 05:11:54 2010 KENTNL [...] cpan.org - Correspondence added

Thanks for taking the time to file a bug report, its appreciated =). Unfortunately I don't have much of a persistent internet connection at present, and I'm only getting on for a few minutes a week at a friends to check mail and soforth, so unfortunately I've gotten a bit behind on my module work :/. If somebody was willing to make a working fix for the module I might be tempted to let them cut a release on my behalf by giving them the needed commit bits =). ( Submit patches to a github fork if you like so I can give them a quick review before you release it =) ) Thanks. Kent Fredric.

Tue Aug 03 05:52:39 2010 KENTNL [...] cpan.org - Taken

Wed Aug 04 07:41:56 2010 KENTNL [...] cpan.org - Correspondence added

Hi. Sorry this took so long. I've just cut a new release, Dist-Zilla-Plugin-ModuleInstall-0.01029216 , which should hopefully resolve your problem. Unfortunately, the problem was more complicated than I'd expected as multiple things broke due to multiple API changes in Dist::Zilla. It should be out soon at a CPAN near you, but if you're in a hurry, this should also work: http://cpan.cpantesters.org/authors/id/K/KE/KENTNL/Dist-Zilla-Plugin-ModuleInstall-0.01029216.tar.gz Thanks again for reporting the bug, and your patience.

Wed Aug 04 07:41:57 2010 KENTNL [...] cpan.org - Status changed from 'open' to 'patched'

Wed Aug 04 17:32:38 2010 KENTNL [...] cpan.org - Fixed in 0.01029216 added

Wed Aug 04 17:32:38 2010 KENTNL [...] cpan.org - Correspondence added

Now the version is visible, marking this as resolved. Reopen if pain persists =). Or if new pains surface, a new bug =)

Wed Aug 04 17:32:39 2010 The RT System itself - Status changed from 'patched' to 'open'

Wed Aug 04 17:32:39 2010 KENTNL [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #55840 for Dist-Zilla-Plugin-ModuleInstall: generated "requires" list is rubbish

Preferred bug tracker