Skip Menu |

This queue is for tickets about the Net-OSCAR CPAN distribution.

Report information
The Basics
Id: 55801
Status: resolved
Priority: 0/
Queue: Net-OSCAR

People
Owner: TODDR [...] cpan.org
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.925
Fixed in: 1.926



Subject: use of defined %hash deprecated in perl 5.12
use of Net::OSCAR will emit copious warnings due to the fact that there is code in Net::OSCAR::Utility that checks for defined %hash (line 168). I have provided a patch via http://github.com/toddr/Net- OSCAR/commit/82e3408e4bdb57ba380958886fcf679e3b0344ca.patch
diff --git a/lib/Net/OSCAR/Utility.pm b/lib/Net/OSCAR/Utility.pm index 2c89e3b..aafee46 100644 --- a/lib/Net/OSCAR/Utility.pm +++ b/lib/Net/OSCAR/Utility.pm @@ -6,8 +6,8 @@ Net::OSCAR::Utility -- internal utility functions for Net::OSCAR package Net::OSCAR::Utility; -$VERSION = '1.925'; -$REVISION = '$Revision: 1.29 $'; +$VERSION = '1.926'; +$REVISION = '$Revision: 1.30 $'; use strict; use vars qw(@ISA @EXPORT $VERSION); @@ -165,7 +165,8 @@ sub tlv_encode($) { my $tlv = shift; my($buffer, $type, $value) = ("", 0, ""); - confess "You must use a tied Net::OSCAR::TLV hash!" unless defined($tlv) and ref($tlv) eq "HASH" and defined(%$tlv) and defined(tied(%$tlv)) and tied(%$tlv)->isa("Net::OSCAR::TLV"); + confess "You must use a tied Net::OSCAR::TLV hash!" + unless defined($tlv) and ref($tlv) eq "HASH" and defined(tied(%$tlv)) and tied(%$tlv)->isa("Net::OSCAR::TLV"); while (($type, $value) = each %$tlv) { $value ||= ""; $buffer .= pack("nna*", $type, length($value), $value);
This will be resolved in version 1.926