Bug #55758 for MediaWiki-DumpFile: When calling subroutine comment ($revision->comment), it throws null pointer exception

Sun Mar 21 10:16:18 2010 ablimit [...] gmail.com - Ticket created

Subject:	Bug Report
Date:	Sun, 21 Mar 2010 10:16:06 -0400
To:	bug-MediaWiki-DumpFile [...] rt.cpan.org
From:	Ablimit Aji <ablimit [...] gmail.com>

*Bug: *When calling subroutine comment ($revision->comment), it throws null pointer exception. *Reason*: in dump file, the <comment></comment> tags may not exist.

Sun Mar 21 12:59:30 2010 triddle [...] cpan.org - Taken

Sun Mar 21 12:59:41 2010 triddle [...] cpan.org - Status changed from 'new' to 'open'

Sun Mar 21 13:03:05 2010 triddle [...] cpan.org - Correspondence added

Thank you for the bug report! This was an oversight on my part and it shows up in other parts of the code as well. Temporarily you should be able to adjust the comment method at line 200 of MediaWiki/DumpFile/Pages.pm to read like this: sub comment { if (defined($_[0]->{tree}->get_elements('comment')) { return $_[0]->{tree}->get_elements('comment')->text; } return ''; } I'll get 0.1.2 released soon (with in a day or two) that'll incorporate a better fix and it'll apply to all the elements that may have 0 occurrences as well. Tyler On Sun Mar 21 10:16:18 2010, ablimit@gmail.com wrote: Show quoted text

> *Bug: *When calling subroutine comment ($revision->comment), it throws null > pointer exception. > > *Reason*: in dump file, the <comment></comment> tags may not exist.

Sun Apr 04 12:36:00 2010 triddle [...] cpan.org - Subject changed from 'Bug Report' to 'When calling subroutine comment ($revision->comment), it throws null pointer exception'

Sun Apr 04 12:36:00 2010 triddle [...] cpan.org - Status changed from 'open' to 'patched'

Sun Apr 04 12:36:01 2010 triddle [...] cpan.org - Severity Normal added

Sun Apr 04 12:36:01 2010 triddle [...] cpan.org - Broken in 0.1.1 added

Sun Apr 04 12:37:39 2010 triddle [...] cpan.org - Correspondence added

I've added a test for this and patched MediaWiki::DumpFile to resolve the issue. I've uploaded the patched version as 0.1.2_01 and it's propagating through CPAN right now. After tests have come back successful I'll release it as an official update. Feel free to test 0.1.2_01 in your environment, there are no API changes. Tyler

Sun Apr 04 12:37:40 2010 The RT System itself - Status changed from 'patched' to 'open'

Thu Apr 08 14:29:03 2010 triddle [...] cpan.org - Correspondence added

I just pushed out 0.1.2 which has this test and fix in it; you should be able to fetch it from CPAN in a few hours.

Thu Apr 08 14:29:04 2010 triddle [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Apr 08 15:07:20 2010 ablimit [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #55758] Resolved: When calling subroutine comment ($revision->comment), it throws null pointer exception
Date:	Thu, 8 Apr 2010 15:07:07 -0400
To:	bug-MediaWiki-DumpFile [...] rt.cpan.org
From:	Ablimit Aji <ablimit [...] gmail.com>

Thanks ! I think it works good now. On Thu, Apr 8, 2010 at 2:29 PM, Tyler Riddle via RT < bug-MediaWiki-DumpFile@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=55758 > > > According to our records, your request has been resolved. If you have any > further questions or concerns, please respond to this message. >

-- Yours Sincerely ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Ablimit Aji

Thu Apr 08 15:07:23 2010 The RT System itself - Status changed from 'resolved' to 'open'

Thu Apr 08 15:43:14 2010 triddle [...] cpan.org - Status changed from 'open' to 'resolved'