Skip Menu |

This queue is for tickets about the Device-USB CPAN distribution.

Report information
The Basics
Id: 55581
Status: resolved
Estimated: 5 min
Worked: 5 min
Priority: 0/
Queue: Device-USB

People
Owner: cpan.wade [...] anomaly.org
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.31
Fixed in: 0.32



Subject: Version test too strict?
t/10-usb-device-accessors.t ....... 1/184 # Failed test '005: Device version' # at t/10-usb-device-accessors.t line 45. # '6.011' # doesn't match '(?-xism:^\d+\.\d\d$)' # Looks like you failed 1 test of 184. t/10-usb-device-accessors.t ....... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/184 subtests Patch: --8<--- t-10.diff --- t/10-usb-device-accessors.t.org 2010-03-15 11:58:56.000000000 +0100 +++ t/10-usb-device-accessors.t 2010-03-15 11:59:00.000000000 +0100 @@ -42,7 +42,7 @@ foreach my $bus (@{$busses}) like( $dev->bMaxPacketSize0(), qr/^\d+$/, "$filename: max packet size" ); like( $dev->idVendor(), qr/^\d+$/, "$filename: vendor id" ); like( $dev->idProduct(), qr/^\d+$/, "$filename: product id" ); - like( $dev->bcdDevice(), qr/^\d+\.\d\d$/, "$filename: Device version" ); + like( $dev->bcdDevice(), qr/^\d+\.\d+$/, "$filename: Device version" ); like( $dev->iManufacturer(), qr/^\d+$/, "$filename: manufacturer index" ); like( $dev->iProduct(), qr/^\d+$/, "$filename: product index" ); like( $dev->iSerialNumber(), qr/^\d+$/, "$filename: serial number index" ); -->8---
On Mon Mar 15 07:00:10 2010, HMBRAND wrote: Show quoted text
> t/10-usb-device-accessors.t ....... 1/184 > # Failed test '005: Device version' > # at t/10-usb-device-accessors.t line 45. > # '6.011' > # doesn't match '(?-xism:^\d+\.\d\d$)' > # Looks like you failed 1 test of 184. > t/10-usb-device-accessors.t ....... Dubious, test returned 1 (wstat > 256, 0x100) > Failed 1/184 subtests
Good catch. That's what I get for believing the spec. I'll release 0.32 shortly with the patch incorporated. Thanks for the help.