Skip Menu |

This queue is for tickets about the Log-Dispatch-FileRotate CPAN distribution.

Report information
The Basics
Id: 55359
Status: resolved
Priority: 0/
Queue: Log-Dispatch-FileRotate
People
Owner: Nobody in particular
Requestors: ABH [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.19
Fixed in: 1.22

History Show all quoted text
  Mon Mar 08 18:06:23 2010 ABH [...] cpan.org - Ticket created
Subject: Depends on Log::Log4perl
The Makefile.PL forces Log::Log4perl to be installed -- but that module isn't actually used as far as I can tell.
  Tue Mar 01 09:01:57 2016 SREZIC [...] cpan.org - Correspondence added
On 2010-03-08 18:06:23, ABH wrote: Show quoted text
> The Makefile.PL forces Log::Log4perl to be installed -- but that > module isn't actually used as far > as I can tell.
It's used for testing, so the dependency should be marked as "test_requires". But probably it's better to make it optional even for testing --- most users will use Log::Dispatch without Log::Log4perl.
  Tue Mar 01 09:01:57 2016 The RT System itself - Status changed from 'new' to 'open'
  Sun Oct 02 13:24:51 2016 MSCHOUT [...] cpan.org - Correspondence added
I've changed it to TestRequires in the git repo for now. It will either remain that way for 1.22, or, if I get to it, I'll redo the test so that its not required at all for testing. Perhaps creating a second test case that doesn't need Log4perl and keeping the exisiting one as well (but skipping if Log4perl is not installed) -- Regards, Michael Schout
  Wed Oct 05 14:00:10 2016 MSCHOUT [...] cpan.org - Correspondence added
Update: I've rewritten the test cases to use Log::Dispatch directly. Log4perl is no longer required at all. Will be in v1.22 when released. -- Regards, Michael Schout
  Wed Oct 05 14:00:39 2016 MSCHOUT [...] cpan.org - Status changed from 'open' to 'patched'
  Thu Jul 27 14:53:10 2017 MSCHOUT [...] cpan.org - Status changed from 'patched' to 'resolved'
  Thu Jul 27 14:53:21 2017 MSCHOUT [...] cpan.org - Fixed in 1.22 added