I believe I have now slain the RT gremlins. Hopefully.
On Mar 2, 2004, at 10:44 PM, via RT wrote:
Show quoted text> This new incarnation ->safe_push in Net::DNS::Packet should do the
> trick:
>
> sub safe_push
> {
> my ($self, $section, @rrs) = @_;
>
> foreach my $rr (@rrs) {
> next if $self->{'seen'}->{$rr->string};
> $self->{'seen'}{$_->string}++;
> $self->push($section, $rr);
> }
> }
>
> with the caveat (in the documentation) that applications that wish to
> have the benefits of ->safe_push() should refrain from using ->push()
> in the same Net::DNS::Packet. Note that this is simply moving the
> housekeeping present in Net::DNS::Packet 0.42 into safe_push. Please
> let me know if this is going in the distribution and on which version,
> so that I can review my code prerequisites.
I'm not in love with having a half-broken safe_push() in the module.
Then again, I'm not convinced of the need for safe_push to begin with.
Then again, I realize that I'm quickly turning into a pedantic old man
in this thread.
Show quoted text> Well, it does its work well enough that 2 million people do not
> complain :) But patches welcome too :D Actually it is interesting.
> Perhaps you might like to take a peek, as together with
> Net::DNS::Server, it provides an alternative framework for your
> Net::DNS::Nameserver.
Interesting that Net::DNS::Method seems to have more users than
Net::DNS. I wonder how you pull that off. Seriously though, I'm am
not questioning the idea or implementation, merely the name. If you
have to look at the docs to figure out what a module does, you need a
better name. As Net::DNS::Method seems to be bits of business logic
for Net::DNS::Server, I would think that it belongs inside the
Net::DNS::Server namespace.
Than again, I try to rule the Net::DNS namespace with an iron first.
Net::DNS::Nameserver isn't mine (Mike Fuhr wrote it, I just look after
it). It was never intended for serious work, but that doesn't seem to
have stopped people. :)
--
Chris Reinhardt -- chris@dyndns.org --
http://www.dyndns.org/
If Stupidity got us into this mess, then why can't it get us out?
--Will Rogers
