Bug #55284 for DBIx-Class-Schema-Loader: Prepositions should not be plural

> Sat Mar 06 10:16:55 2010: Request 55284 was acted upon. > Transaction: Ticket created by OVID > Queue: DBIx-Class-Schema-Loader > Subject: Prepositions should not be plural > Broken in: 0.05003 > Severity: Normal > Owner: Nobody > Requestors: ovid@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55284 > > > > Need to rethink some of the naming. I just got the following warning in > 0.05003: > > DBIx::Class::Schema::Loader::RelBuilder 0.05003: warning, stripping > trailing _id from Veure::Schema::Result::User relation 'email_to_ids', > renaming to 'email_toes'. This behavior is new as of 0.05003. > DBIx::Class::Schema::Loader::RelBuilder 0.05003: warning, stripping > trailing _id from Veure::Schema::Result::User relation 'email_from_ids', > renaming to 'email_froms'. This behavior is new as of 0.05003. > > "email_froms" is bad enough, but "email_toes"? > > If you're going to infer names, prepositions should not be plural. > "emails_to" and "emails_from" would make this easier. > > Cheers, > Ovid

----- Original Message ---- The column names are "from_id" and "to_id'. The relevant tables are below. And I was laughing when I saw it. Fortunately, it's a personal project and this is part of the system I'm not working on yet :) veure=# \d email Table "public.email" Column | Type | Modifiers ----------+-----------------------------+---------------------------------------------------- id | integer | not null default nextval('email_id_seq'::regclass) from_id | integer | not null to_id | integer | not null datesent | timestamp without time zone | not null default now() message | text | not null Indexes: "email_pkey" PRIMARY KEY, btree (id) Foreign-key constraints: "email_from_id_fkey" FOREIGN KEY (from_id) REFERENCES users(id) "email_to_id_fkey" FOREIGN KEY (to_id) REFERENCES users(id) veure=# \d users Table "public.users" Column | Type | Modifiers ----------------------+------------------------+---------------------------------------------------- id | integer | not null default nextval('users_id_seq'::regclass) username | character varying(100) | not null password | character varying(100) | not null email | character varying(255) | not null current_character_id | integer | Indexes: "users_pkey" PRIMARY KEY, btree (id) "users_email_key" UNIQUE, btree (email) "users_username_key" UNIQUE, btree (username) Foreign-key constraints: "current_character_fk" FOREIGN KEY (current_character_id) REFERENCES characters(id) DEFERRABLE INITIALLY DEFERRED Referenced by: TABLE "characters" CONSTRAINT "characters_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(id) DEFERRABLE INITIALLY DEFERRED TABLE "email" CONSTRAINT "email_from_id_fkey" FOREIGN KEY (from_id) REFERENCES users(id) TABLE "email" CONSTRAINT "email_to_id_fkey" FOREIGN KEY (to_id) REFERENCES users(id) TABLE "user_role" CONSTRAINT "user_role_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(id) DEFERRABLE INITIALLY DEFERRED Cheers, Ovid-- Buy the book - http://www.oreilly.com/catalog/perlhks/ Tech blog - http://use.perl.org/~Ovid/journal/ Twitter - http://twitter.com/OvidPerl Official Perl 6 Wiki - http://www.perlfoundation.org/perl6

----- Original Message ---- Ah, "emails_to" is much better. Thank you :) A couple of questions. First, why is "integer" now quoted below? (for dogs) Just aesthetics? Right now I'm trying to minimize "non-changes" in my schema code so that other developers aren't trolling through large, non-functional commits. - data_type: integer + data_type: 'integer' default_value: nextval('visa_id_seq'::regclass) is_auto_increment: 1 is_nullable: 0 Also, I'm getting one test failure: t/10sqlite_common.t ..................... 1/167 Can't locate object method "has_relationship" via package "DBIXCSL_Test::Schema::LoaderTest4" at t/lib/dbixcsl_common_tests.pm line 514. Below my sig is the tail of the test run. Cheers, Ovid-- Buy the book - http://www.oreilly.com/catalog/perlhks/ Tech blog - http://use.perl.org/~Ovid/journal/ Twitter - http://twitter.com/OvidPerl Official Perl 6 Wiki - http://www.perlfoundation.org/perl6 ok 70 - Foreign key detected ok 71 - The object isa DBIXCSL_Test::Schema::LoaderTest4 Can't locate object method "has_relationship" via package "DBIXCSL_Test::Schema::LoaderTest4" at t/lib/dbixcsl_common_tests.pm line 514. # Looks like you planned 167 tests but ran 71. # Looks like your test exited with 2 just after 71. Dubious, test returned 2 (wstat 512, 0x200) Failed 96/167 subtests Test Summary Report ------------------- t/10sqlite_common.t (Wstat: 512 Tests: 71 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 167 tests but ran 71. Files=1, Tests=71, 1 wallclock secs ( 0.04 usr 0.01 sys + 0.71 cusr 0.21 csys = 0.97 CPU) Result: FAIL