Bug #55158 for Crypt-IDEA: Win32 patch - support for mingw-w64 gcc toolchain

Tue Mar 02 18:43:34 2010 kmx [...] cpan.org - Ticket created

Subject:

Win32 patch - support for mingw-w64 gcc toolchain

Hi,

could you please confider the following path to _idea.c

#ifdef WIN32
+ #include <windows.h>
#include <wininet.h>
# else
#include <netinet/in.h>
# endif

The poposed patch works nice with:
- 32bit gcc3 by mingw.org
- 32bit gcc4 by mingw-w64.sf.net
- 64bit gcc4 by mingw-w64.sf.net

Thanks in advance for any feedback.

--
kmx

Tue Mar 02 21:37:03 2010 csjewell [...] cpan.org - Correspondence added

I will specify that while the current module works with the mingw32-gcc3 toolchain that Strawberry Perl is currently using without patching, we plan to move to the two aforementioned gcc4 toolchain with the 5.12.x.x versions, and this module is used as part of the "crypto toolchain" that Module::Signature relies on. So this is a blocker for those versions. Please release a fix with the included patch.

Tue Mar 02 21:37:04 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Mar 02 22:43:24 2010 dparis [...] w3works.com - Correspondence added

Subject:	Re: [rt.cpan.org #55158] Win32 patch - support for mingw-w64 gcc toolchain
Date:	Tue, 02 Mar 2010 22:42:19 -0500
To:	bug-Crypt-IDEA [...] rt.cpan.org
From:	Dave Paris <dparis [...] w3works.com>

Mr. Jewell, First, I'm quite capable of deducing the conclusion you state below. Second, the ticket was opened less than three hours prior to your comment. I would request an apology for your final tone, implying I have no plans on issuing a subsequent, patched version and in the future, attempt to restrain yourself for 24-48 hours after the submission of a ticket. This gives the module maintainer an ample, if minimal, amount of time to adequately patch, test, and update. Or at least reply to the ticket. If you find this to be offensive, it is merely an in-kind reply. Followups will not be responded to. I will update CPAN with a tested, patched module once a full regression test is passed on all main (Win32, *nix, OS X, Solaris, etc) platforms. Regards, -dsp Curtis Jewell via RT wrote: Show quoted text

> Queue: Crypt-IDEA > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55158 > > > I will specify that while the current module works with the mingw32-gcc3 > toolchain that Strawberry Perl is currently using without patching, we > plan to move to the two aforementioned gcc4 toolchain with the 5.12.x.x > versions, and this module is used as part of the "crypto toolchain" that > Module::Signature relies on. > > So this is a blocker for those versions. Please release a fix with the > included patch.

Wed Mar 03 04:32:14 2010 kmx [...] cpan.org - Correspondence added

Hi Dave,

Show quoted text

> I will update CPAN with a tested, patched module once a full
> regression test is passed on all main (Win32, *nix, OS X, Solaris,
> etc) platforms.

I am not sure if you have noticed that my proposed 1-line patch is all inside #ifdef _WIN32 ... #endif so perhaps it has not such a significant impact on *nix, OS X, Solaris and other platforms.

Anyway, thaks for your prompt feedback (even though slightly heated).

--
kmx

Thu Mar 04 03:59:07 2010 csjewell [...] cpan.org - Correspondence added

I'm sorry about the tone. I know I'm not the most tactful person out there. I meant to be informative as to why we ask without adding a perjorative "jump on your case tone". Thanks for both your work, and for letting me know that I did tone that badly. I'll be more careful in the future. --Curtis

Mon Jul 12 14:12:47 2010 kmx [...] cpan.org - Correspondence added

Hi Dave,

can I help somehow with getting the one-line-patch from my first post into Crypt-IDEA release?

--
kmx

Wed Jun 15 08:58:29 2011 vvm [...] tut.by - Correspondence added

From:

vvm [...] tut.by

On Tue Mar 02 18:43:34 2010, KMX wrote: Show quoted text

> could you please confider the following path to _idea.c > > #ifdef WIN32 > + #include <windows.h> > #include <wininet.h> > # else > #include <netinet/in.h> > # endif

Patch work Ok . . .

Tue Oct 18 02:16:46 2011 kmx [...] cpan.org - Correspondence added

Hi Dave,

can I help somehow with getting the one-line-patch from my first post into Crypt-IDEA release?

If you give me co-maint I can handle Crypt-IDEA release.

Please give me any kind of feedback.

--
kmx

Tue Oct 18 06:29:25 2011 dparis [...] w3works.com - Correspondence added

Subject:	Re: [rt.cpan.org #55158] Win32 patch - support for mingw-w64 gcc toolchain
Date:	Tue, 18 Oct 2011 06:29:16 -0400
To:	bug-Crypt-IDEA [...] rt.cpan.org
From:	Dave Paris <dparis [...] w3works.com>

I'll patch it later today and send it to you for testing. Thanks! On Tue, Oct 18, 2011 at 2:16 AM, kmx via RT <bug-Crypt-IDEA@rt.cpan.org> wrote: Show quoted text

> Queue: Crypt-IDEA > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55158 > > > Hi Dave, > > can I help somehow with getting the one-line-patch from my first post into > Crypt-IDEA release? > > If you give me co-maint I can handle Crypt-IDEA release. > > Please give me any kind of feedback. > > -- > kmx > >

Tue Jul 23 11:57:21 2013 DPARIS [...] cpan.org - Correspondence added

This ticket has been resolved in release 1.09 which has been uploaded to PAUSE. -dsp

Tue Jul 23 11:57:22 2013 DPARIS [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jul 23 11:57:28 2013 DPARIS [...] cpan.org - Taken