Skip Menu |

This queue is for tickets about the DBIx-Log4perl CPAN distribution.

Report information
The Basics
Id: 55143
Status: resolved
Priority: 0/
Queue: DBIx-Log4perl

People
Owner: Nobody in particular
Requestors: ezylby [...] yahoo.fr
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.21



Subject: DBIx::Log4perl v0.19 : execute_array() : ArrayTupleStatus is printed at INFO level instead of DEBUG
Date: Tue, 2 Mar 2010 15:21:37 +0000 (GMT)
To: bug-DBIx-Log4perl [...] rt.cpan.org
From: Eric ZYLBERSTEJN <ezylby [...] yahoo.fr>
Hello, Whenever I call execute_array(), the tuple status array gets printed at INFO level: 2010/03/02 15:34:18 INFO YYY::XXXXXXNotif::reserve 256> $ArrayTupleStatus = [ -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1 ]; This is caused by the following lines in DBIx/Log4perl/st.pm : 1 # $Id: st.pm 284 2006-09-07 13:50:57Z martin $ 169 $sth->_dbix_l4p_info(2, sub {Data::Dumper->Dump( 170 [$array_tuple_status], ['ArrayTupleStatus'])}) 171 if ($h->{logmask} & DBIX_L4P_LOG_INPUT); I locally changed line 169 to this : 169 $sth->_dbix_l4p_debug($h, 2, sub {Data::Dumper->Dump( 170 [$array_tuple_status], ['ArrayTupleStatus'])}) I am now getting : 2010/03/02 16:16:48 DEBUG XXX::YYYYYYNotif::reserve 256> $ArrayTupleStatus = [-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1]; Best regards Eric
On Tue Mar 02 10:22:50 2010, ezylby@yahoo.fr wrote: Show quoted text
> Hello, > > Whenever I call execute_array(), the tuple status array gets printed > at INFO level: > > 2010/03/02 15:34:18 INFO YYY::XXXXXXNotif::reserve 256> > $ArrayTupleStatus = [ > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1, > -1 > ]; > > This is caused by the following lines in DBIx/Log4perl/st.pm : > > > 1 # $Id: st.pm 284 2006-09-07 13:50:57Z martin $ > > 169 $sth->_dbix_l4p_info(2, sub {Data::Dumper->Dump( > 170 [$array_tuple_status], ['ArrayTupleStatus'])}) > 171 if ($h->{logmask} & DBIX_L4P_LOG_INPUT); > > I locally changed line 169 to this : > > 169 $sth->_dbix_l4p_debug($h, 2, sub {Data::Dumper->Dump( > 170 [$array_tuple_status], ['ArrayTupleStatus'])}) > > I am now getting : > > 2010/03/02 16:16:48 DEBUG XXX::YYYYYYNotif::reserve 256> > $ArrayTupleStatus = [-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1]; > > Best regards > > Eric > > > >
Thanks for spotting this and identifying the problem code. I will fix this for the next release. Martin -- Martin J. Evans Wetherby, UK
On Tue Mar 02 10:22:50 2010, ezylby@yahoo.fr wrote: Show quoted text
> Hello, > > Whenever I call execute_array(), the tuple status array gets printed > at INFO level: >
<snipped> I've updated DBIx::Log4perl with your change and uploaded it as version 0.20 to CPAN where it should appear shortly. I also draw your attention to a new constant DBIX_L4P_LOG_DELAYBINDPARAM which I've added a few other fixes (see Changes file). Thanks again for the fix and I'll mark this rt fixed when rt sees v0.20. Martin -- Martin J. Evans Wetherby, UK
Subject: Re : [rt.cpan.org #55143] DBIx::Log4perl v0.19 : execute_array() : ArrayTupleStatus is printed at INFO level instead of DEBUG
Date: Wed, 3 Mar 2010 15:40:35 +0000 (GMT)
To: bug-DBIx-Log4perl [...] rt.cpan.org
From: Eric ZYLBERSTEJN <ezylby [...] yahoo.fr>
Hi, I am now getting an error with version 0.20. I think line 180 should read : 180 $sth->_dbix_l4p_debug($h, 2, sub {Data::Dumper->Dump( $h is missing. Regards Eric ----- Message d'origine ---- De : Martin J Evans via RT <bug-DBIx-Log4perl@rt.cpan.org> À : ezylby@yahoo.fr Envoyé le : Mer 3 Mars 2010, 0 h 49 min 53 s Objet : [rt.cpan.org #55143] DBIx::Log4perl v0.19 : execute_array() : ArrayTupleStatus is printed at INFO level instead of DEBUG <URL: https://rt.cpan.org/Ticket/Display.html?id=55143 > On Tue Mar 02 10:22:50 2010, ezylby@yahoo.fr wrote: Show quoted text
> Hello, > > Whenever I call execute_array(), the tuple status array gets printed > at INFO level: >
<snipped> I've updated DBIx::Log4perl with your change and uploaded it as version 0.20 to CPAN where it should appear shortly. I also draw your attention to a new constant DBIX_L4P_LOG_DELAYBINDPARAM which I've added a few other fixes (see Changes file). Thanks again for the fix and I'll mark this rt fixed when rt sees v0.20. Martin -- Martin J. Evans Wetherby, UK
On Wed Mar 03 10:41:48 2010, ezylby@yahoo.fr wrote: Show quoted text
> Hi, > > I am now getting an error with version 0.20. > > I think line 180 should read : > 180 $sth->_dbix_l4p_debug($h, 2, sub {Data::Dumper->Dump( > > $h is missing. > > Regards > > Eric
Sincere apologies - don't know how that happened. Martin -- Martin J. Evans Wetherby, UK
On Wed Mar 03 10:41:48 2010, ezylby@yahoo.fr wrote: Show quoted text
> Hi, > > I am now getting an error with version 0.20. > > I think line 180 should read : > 180 $sth->_dbix_l4p_debug($h, 2, sub {Data::Dumper->Dump( > > $h is missing. > > Regards > > Eric >
Changes in 0.21: 0.21 Wed March 3 2010 I did not have a good day yesterday - lesson to be learnt, do not release new versions to cpan late at night. Fixed bug introduced whilst attempting to fix rt 55143 (should only effect people using execute_array and tuple status. Minor pod formatting changes/fixes. Once again - sorry and thank you. Martin -- Martin J. Evans Wetherby, UK
Subject: Re : [rt.cpan.org #55143] DBIx::Log4perl v0.19 : execute_array() : ArrayTupleStatus is printed at INFO level instead of DEBUG
Date: Thu, 4 Mar 2010 14:04:23 +0000 (GMT)
To: bug-DBIx-Log4perl [...] rt.cpan.org
From: Eric ZYLBERSTEJN <ezylby [...] yahoo.fr>
Hi, Show quoted text
> Changes in 0.21:
Works fine. Thanks. Very handy module. Best regards Eric
On Thu Mar 04 09:04:52 2010, ezylby@yahoo.fr wrote: Show quoted text
> Hi, >
> > Changes in 0.21:
> > > Works fine. Thanks. Very handy module. > > Best regards > > Eric > > >
Cheers. You might think this is cheeky but I wonder if you would be prepared to add a quick review to this effect on cpan (http://cpanratings.perl.org/dist/DBIx-Log4perl). I'll close this rt now. Martin -- Martin J. Evans Wetherby, UK