Bug #55132 for Module-Install: "make install" doesn't honor MANIFEST.SKIP

Tue Mar 02 06:32:02 2010 marcoep [...] gmail.com - Ticket created

Subject:

"make install" doesn't honor MANIFEST.SKIP

Hi there, It looks like "make install" doesn't honor MANIFEST.SKIP: $ grep skip-foo MANIFEST $ grep skip-foo MANIFEST.SKIP skip-foo $ make skipcheck 2>&1 | grep skip-foo Skipping blib/lib/DMWeb/skip-foo Skipping skip-foo $ make install 2>&1 | grep skip-foo Installing /data/home/poleggim/tmp/perl/lib/perl5/DMWeb/skip-foo Though 'skip-foo' is correctly skipped when building a distribution package: $ make dist 2>&1 | grep skip-foo $ gtar ztvf DMWeb-3.1.901.tar.gz | grep skip-foo Am I missing something? Best, Marco

Thu Mar 04 18:39:54 2010 ishigaki [...] cpan.org - Correspondence added

Hi. Which version of 1) Module::Install, 2) ExtUtils::Manifest, 3) ExtUtils::Install, 4) OS do you use? And does your Makefile.PL have "install_share()"? Please give us more detailed information like complete Makefile.PL/install log etc to know what's going on. On 2010-3-02 Tue 06:32:02, marcoep@gmail.com wrote: Show quoted text

> Hi there, > > It looks like "make install" doesn't honor MANIFEST.SKIP: > > $ grep skip-foo MANIFEST > > $ grep skip-foo MANIFEST.SKIP > skip-foo > > $ make skipcheck 2>&1 | grep skip-foo > Skipping blib/lib/DMWeb/skip-foo > Skipping skip-foo > > $ make install 2>&1 | grep skip-foo > Installing /data/home/poleggim/tmp/perl/lib/perl5/DMWeb/skip-foo > > Though 'skip-foo' is correctly skipped when building a distribution

package: Show quoted text

> > $ make dist 2>&1 | grep skip-foo > $ gtar ztvf DMWeb-3.1.901.tar.gz | grep skip-foo > > Am I missing something? > > Best, > > Marco

Thu Mar 04 18:39:55 2010 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 04 18:39:56 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'stalled'

Thu Mar 04 23:58:55 2010 adam [...] ali.as - Correspondence added

Subject:	Re: [rt.cpan.org #55132] "make install" doesn't honor MANIFEST.SKIP
Date:	Fri, 5 Mar 2010 15:57:58 +1100
To:	bug-Module-Install [...] rt.cpan.org
From:	Adam Kennedy <adamkennedybackup [...] gmail.com>

Is MANIFEST supposed to have any relationship with make install at all? MANIFEST describes the list of files in the tarball, MANIFEST.SKIP lists the patterns to exclude from manifest. Both of these are dist-time features, not install time features. I could be wrong though... Adam K On 2 March 2010 22:32, Marco Emilio Poleggi via RT <bug-Module-Install@rt.cpan.org> wrote: Show quoted text

> Tue Mar 02 06:32:02 2010: Request 55132 was acted upon. > Transaction: Ticket created by marcoep@gmail.com > Queue: Module-Install > Subject: "make install" doesn't honor MANIFEST.SKIP > Broken in: 0.94 > Severity: Normal > Owner: Nobody > Requestors: marcoep@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55132 > > > > Hi there, > > It looks like "make install" doesn't honor MANIFEST.SKIP: > > $ grep skip-foo MANIFEST > > $ grep skip-foo MANIFEST.SKIP > skip-foo > > $ make skipcheck 2>&1 | grep skip-foo > Skipping blib/lib/DMWeb/skip-foo > Skipping skip-foo > > $ make install 2>&1 | grep skip-foo > Installing /data/home/poleggim/tmp/perl/lib/perl5/DMWeb/skip-foo > > Though 'skip-foo' is correctly skipped when building a distribution package: > > $ make dist 2>&1 | grep skip-foo > $ gtar ztvf DMWeb-3.1.901.tar.gz | grep skip-foo > > Am I missing something? > > Best, > > Marco >

Thu Mar 04 23:58:56 2010 The RT System itself - Status changed from 'stalled' to 'open'

Wed Mar 10 13:03:00 2010 marcoep [...] gmail.com - Correspondence added

From:

marcoep [...] gmail.com

Hi there, More info: $ perl -V Summary of my perl5 (revision 5 version 8 subversion 7) configuration: Platform: osname=solaris, osvers=2.10, archname=sun4-solaris uname='sunos 5.10 s10_60 sun4u sparc sunw,ultra-5_10 ' Relevant modules: ExtUtils::Install 1.52 ExtUtils::MakeMaker 6.56 ExtUtils::Manifest 1.56 Module::Install 0.94 No install_share() in Makefile.PL Le Jeu 04 Mar 2010 23:58:55, adam@ali.as a écrit : Show quoted text

> Is MANIFEST supposed to have any relationship with make install at > all?

Good question, I guess the ExtUtils::Install's and ExtUtils::Manifest's guys should be able to answer this (at least "philosophically"). Show quoted text

> > MANIFEST describes the list of files in the tarball, MANIFEST.SKIP > lists the patterns to exclude from manifest. > > Both of these are dist-time features, not install time features.

Right, but what does it happen exactly when one calls "make install"? It looks like it picks up whatever it founds recursively... BTW, I found that using an INSTALL.SKIP file (as per ExtUtils::Install) solves the issue. So, this ticket is probably invalid. Nonetheless a mention of ExtUtils::Install in the documentation would be helpful. Cheers, Marco Show quoted text

> > I could be wrong though... > > Adam K > > On 2 March 2010 22:32, Marco Emilio Poleggi via RT > <bug-Module-Install@rt.cpan.org> wrote:

> > Tue Mar 02 06:32:02 2010: Request 55132 was acted upon. > > Transaction: Ticket created by marcoep@gmail.com > > Queue: Module-Install > > Subject: "make install" doesn't honor MANIFEST.SKIP > > Broken in: 0.94 > > Severity: Normal > > Owner: Nobody > > Requestors: marcoep@gmail.com > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55132 > > > > > > > Hi there, > > > > It looks like "make install" doesn't honor MANIFEST.SKIP: > > > > $ grep skip-foo MANIFEST > > > > $ grep skip-foo MANIFEST.SKIP > > skip-foo > > > > $ make skipcheck 2>&1 | grep skip-foo > > Skipping blib/lib/DMWeb/skip-foo > > Skipping skip-foo > > > > $ make install 2>&1 | grep skip-foo > > Installing /data/home/poleggim/tmp/perl/lib/perl5/DMWeb/skip-foo > > > > Though 'skip-foo' is correctly skipped when building a distribution

> package:

> > > > $ make dist 2>&1 | grep skip-foo > > $ gtar ztvf DMWeb-3.1.901.tar.gz | grep skip-foo > > > > Am I missing something? > > > > Best, > > > > Marco > >

Wed Mar 10 20:46:55 2010 ishigaki [...] cpan.org - Correspondence added

Try "make clean" first to remove your (probably stale) blib directory, and then confirm your MANIFEST.SKIP has a "skip-foo" entry, and do "perl Makefile.PL && make" again. If you still have "blib/lib/DMWeb/ skip-foo" (which will be installed when you "make install"), then most probably it's a bug in ExtUtils::Manifest, so please forward this to its queue. If not, that's because your blib directory had an old skip- foo file which probably you forgot to remove while testing. There may be other factors I don't take into account (don't you use any functions to copy things into blib sub-directories, right?), but for now I close this ticket as "not for us". If you still think this is our bug, please reopen this. Thanks. On 2010-3-10 Wed 13:03:00, marcoep@gmail.com wrote: Show quoted text

> Hi there, > > More info: > > $ perl -V > Summary of my perl5 (revision 5 version 8 subversion 7)

configuration: Show quoted text

> Platform: > osname=solaris, osvers=2.10, archname=sun4-solaris > uname='sunos 5.10 s10_60 sun4u sparc sunw,ultra-5_10 ' > > Relevant modules: > > ExtUtils::Install 1.52 > ExtUtils::MakeMaker 6.56 > ExtUtils::Manifest 1.56 > Module::Install 0.94 > > No install_share() in Makefile.PL > > Le Jeu 04 Mar 2010 23:58:55, adam@ali.as a écrit :

> > Is MANIFEST supposed to have any relationship with make install at > > all?

> > Good question, I guess the ExtUtils::Install's and

ExtUtils::Manifest's Show quoted text

> guys should be able to answer this (at least "philosophically"). >

> > > > MANIFEST describes the list of files in the tarball, MANIFEST.SKIP > > lists the patterns to exclude from manifest. > > > > Both of these are dist-time features, not install time features.

> > Right, but what does it happen exactly when one calls "make install"?

It Show quoted text

> looks like it picks up whatever it founds recursively... > > BTW, I found that using an INSTALL.SKIP file (as per

ExtUtils::Install) Show quoted text

> solves the issue. So, this ticket is probably invalid. Nonetheless a > mention of ExtUtils::Install in the documentation would be helpful. > > Cheers, > > Marco > >

> > > > I could be wrong though... > > > > Adam K > > > > On 2 March 2010 22:32, Marco Emilio Poleggi via RT > > <bug-Module-Install@rt.cpan.org> wrote:

> > > Tue Mar 02 06:32:02 2010: Request 55132 was acted upon. > > > Transaction: Ticket created by marcoep@gmail.com > > > Queue: Module-Install > > > Subject: "make install" doesn't honor MANIFEST.SKIP > > > Broken in: 0.94 > > > Severity: Normal > > > Owner: Nobody > > > Requestors: marcoep@gmail.com > > > Status: new > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=55132 > > > > > > > > > > Hi there, > > > > > > It looks like "make install" doesn't honor MANIFEST.SKIP: > > > > > > $ grep skip-foo MANIFEST > > > > > > $ grep skip-foo MANIFEST.SKIP > > > skip-foo > > > > > > $ make skipcheck 2>&1 | grep skip-foo > > > Skipping blib/lib/DMWeb/skip-foo > > > Skipping skip-foo > > > > > > $ make install 2>&1 | grep skip-foo > > > Installing /data/home/poleggim/tmp/perl/lib/perl5/DMWeb/skip-foo > > > > > > Though 'skip-foo' is correctly skipped when building a

distribution Show quoted text

> > package:

> > > > > > $ make dist 2>&1 | grep skip-foo > > > $ gtar ztvf DMWeb-3.1.901.tar.gz | grep skip-foo > > > > > > Am I missing something? > > > > > > Best, > > > > > > Marco > > >

> >

Wed Mar 10 20:46:59 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'rejected'

Thu Mar 11 05:35:50 2010 marcoep [...] gmail.com - Correspondence added

From:

marcoep [...] gmail.com

Le Mer 10 Mar 2010 20:46:55, ISHIGAKI a écrit : Show quoted text

> Try "make clean" first to remove your (probably stale) blib directory, > and then confirm your MANIFEST.SKIP has a "skip-foo" entry, and do > "perl Makefile.PL && make" again. If you still have "blib/lib/DMWeb/ > skip-foo" (which will be installed when you "make install"), then most > probably it's a bug in ExtUtils::Manifest, so please forward this to > its queue. If not, that's because your blib directory had an old skip- > foo file which probably you forgot to remove while testing. There may > be other factors I don't take into account (don't you use any functions > to copy things into blib sub-directories, right?), but for now I close > this ticket as "not for us". If you still think this is our bug, please > reopen this. Thanks. >

Hi, after every test I did, I always run a "make realclean", so no risk at all to stumble upon stale stuff. I know pretty well the nastiness of forgetting the blib/ there ;-). I now believe there's no bug indeed, just a lack of information about the (rather complicated) build process. I just ended up over INSTALL.SKIP after digging the whole chain of doc pages: its use make indeed sense, 'cause, as Adam said, the manifest stuff relates to distribution building. A possible improvement for M::I (or lower down the chain), might be automatically handling of INSTALL.SKIP = MANIFEST.SKIP, though, beware of putting a line like this in INSTALL.SKIP ^blib 'cause nothing at all would be installed!? Conversely, that's perfectly "legal" in MANIFEST.SKIP... Really puzzled. Thanks anyway! Marco

Thu Mar 11 05:35:58 2010 The RT System itself - Status changed from 'rejected' to 'open'

Thu Mar 11 05:44:44 2010 marcoep [...] gmail.com - Correspondence added

From:

marcoep [...] gmail.com

Oops, sorry my reply automatically reopened the ticket and now the interface doesn't allow me to change its status (I'm redirected to the search page). Oh, RT goodness...