Bug #55087 for MooseX-ChainedAccessors: Simplify the accessor trait for future compatibility

Mon Mar 01 03:12:06 2010 onken [...] netcubed.de - Ticket created

Subject:

Simplify the accessor trait for future compatibility

Hi, I tried to simplify the accessor trait to compatible with future changes to the inline code. All tests pass. package MooseX::ChainedAccessors::Accessor; use strict; use warnings; use base 'Moose::Meta::Method::Accessor'; our $VERSION = '0.01'; sub _inline_post_body { return 'return $_[0] if (scalar(@_) >= 2);' . "\n"; } 1;

Tue Nov 02 13:44:00 2010 SHLOMIF [...] cpan.org - Correspondence added

RT-Send-CC:

modules [...] perl.org

On Mon Mar 01 03:12:06 2010, PERLER wrote: Show quoted text

> Hi, > > I tried to simplify the accessor trait to compatible with future changes > to the inline code. > > All tests pass. > > > package MooseX::ChainedAccessors::Accessor; > use strict; > use warnings; > > use base 'Moose::Meta::Method::Accessor'; > > our $VERSION = '0.01'; > > sub _inline_post_body { > return 'return $_[0] if (scalar(@_) >= 2);' . "\n"; > } > > 1;

Thanks for that patch-like change. Thanks to mst on IRC I've understood that it fixes my newer ticket for this bug (about breaking with recent Moose), and I've implemented a fix for it in the github clone: http://github.com/shlomif/MooseX-ChainedAccessors I'd like to wait a few weeks for the author's response and if not would like to receive co-maint for this module, so I can upload an up-to-date version to CPAN. Regards, -- Shlomi Fish

Tue Nov 02 13:44:01 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 02 13:50:44 2010 SHLOMIF [...] cpan.org - Correspondence added

RT-Send-CC:

david [...] dmclaughlin.com, modules [...] perl.org

On Tue Nov 02 13:44:00 2010, SHLOMIF wrote: Show quoted text

> On Mon Mar 01 03:12:06 2010, PERLER wrote:

> > Hi, > > > > I tried to simplify the accessor trait to compatible with future changes > > to the inline code. > > > > All tests pass. > > > > > > package MooseX::ChainedAccessors::Accessor; > > use strict; > > use warnings; > > > > use base 'Moose::Meta::Method::Accessor'; > > > > our $VERSION = '0.01'; > > > > sub _inline_post_body { > > return 'return $_[0] if (scalar(@_) >= 2);' . "\n"; > > } > > > > 1;

> > Thanks for that patch-like change. Thanks to mst on IRC I've understood > that it fixes my newer ticket for this bug (about breaking with recent > Moose), and I've implemented a fix for it in the github clone: > > http://github.com/shlomif/MooseX-ChainedAccessors > > I'd like to wait a few weeks for the author's response and if not would > like to receive co-maint for this module, so I can upload an up-to-date > version to CPAN. > > Regards, > > -- Shlomi Fish

David, care to comment? You seem to be alive judging by your Twitter. Regards, -- Shlomi Fish

Tue Mar 01 06:46:47 2011 onken [...] netcubed.de - Correspondence added

Fixed in 0.02

Tue Mar 01 06:46:47 2011 onken [...] netcubed.de - Status changed from 'open' to 'resolved'