Bug #55050 for Module-Install: Module::Install::AuthorTests is broken with M::I 0.93 and 0.94

Sat Feb 27 18:51:14 2010 avar [...] cpan.org - Ticket created

Subject:

Module::Install::AuthorTests is broken with M::I 0.93 and 0.94

Any Makefile.PL that uses C<< author_tests('xt') >> is broken with M::I 0.93-0.94 because that will add xt/*.t to the test list twice, e.g.: [...] t/*.t xt/*.t xt/*.t Tap::Harness then fails with: xt/01_pod.t ....................... ok xt/01_pod.t ....................... ok You already have a parser for (xt/01_pod.t). Perhaps you have run the same test twice. at /usr/share/perl/5.10/TAP/Harness.pm line 489 make: *** [test_dynamic] Error 25

Sun Feb 28 00:47:07 2010 ishigaki [...] cpan.org - Correspondence added

Hi. Which version of Module::Install, ::AuthorTests, and version/kind of OS did you use for your test? I just added a test case in the trunk but I couldn't reproduce what you reported. Looking forward to further information. Thanks. On 2010-2-27 Sat 18:51:14, AVAR wrote: Show quoted text

> Any Makefile.PL that uses C<< author_tests('xt') >> is broken with

M::I Show quoted text

> 0.93-0.94 because that will add xt/*.t to the test list twice, e.g.: > > [...] t/*.t xt/*.t xt/*.t > > Tap::Harness then fails with: > > xt/01_pod.t ....................... ok > xt/01_pod.t ....................... ok > You already have a parser for (xt/01_pod.t). Perhaps you have run

the Show quoted text

> same test twice. at /usr/share/perl/5.10/TAP/Harness.pm line 489 > make: *** [test_dynamic] Error 25 >

Sun Feb 28 00:47:08 2010 The RT System itself - Status changed from 'new' to 'open'

Sun Feb 28 00:47:08 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'stalled'

Sun Feb 28 01:22:16 2010 avar [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #55050] Module::Install::AuthorTests is broken with M::I 0.93 and 0.94
Date:	Sun, 28 Feb 2010 06:21:20 +0000
To:	bug-Module-Install [...] rt.cpan.org
From:	Ævar Arnfjörð Bjarmason <avar [...] cpan.org>

On Sun, Feb 28, 2010 at 05:47, Kenichi Ishigaki via RT <bug-Module-Install@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=55050 > > > Hi. Which version of Module::Install, ::AuthorTests, and version/kind > of OS did you use for your test? I just added a test case in the trunk > but I couldn't reproduce what you reported. Looking forward to further > information. Thanks.

I tested M::I 0.93 and 0.94 as cited in the report, I used Module::Install::AuthorTests 0.002 which hasn't been updated since 2008. This was on Ubuntu 9.10 / Debian testing. The problem is this: 3994 adamk@cpan.org File::Find::find( \&_wanted_t, $dir ); 11432 adamk@cpan.org if ( -d 'xt' and ($Module::Install::AUTHOR or $ENV{RELEASE_TESTING}) ) { 11275 adamk@cpan.org File::Find::find( \&_wanted_t, 'xt' ); 11275 adamk@cpan.org } 3994 adamk@cpan.org $self->tests( join ' ', map { "$_/*.t" } sort keys %test_dir ); If the xt directory exists M::I 0.9[34] will add it to tests, the problem is that AuthorTests (which I gather is a commonly used M::I plugin) also does this and TAP::Harness croaks as a result because it starts running duplicate tests.

Sun Feb 28 01:22:17 2010 The RT System itself - Status changed from 'stalled' to 'open'

Sun Feb 28 01:31:16 2010 avar [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #55050] Module::Install::AuthorTests is broken with M::I 0.93 and 0.94
Date:	Sun, 28 Feb 2010 06:30:22 +0000
To:	bug-Module-Install [...] rt.cpan.org
From:	Ævar Arnfjörð Bjarmason <avar [...] cpan.org>

If you want a real world testcase just: git clone git://github.com/hinrik/hailo.git Then add author_tests 'xt'; to the end of the Makefile.PL and run it. It'll add two xt/*.t entries to the list of tests run.

Sun Feb 28 02:33:20 2010 ishigaki [...] cpan.org - Correspondence added

OK. I got the picture. This is primarily a bug of ::AuthorTests which should be responsible not to add duped directory, but this kind of duplication may occur in other cases/combinations, so I added a simple check in the trunk to filter the duplication. So, this will be fixed in the next release. Thanks. On 2010-2-28 Sun 01:31:16, AVAR wrote: Show quoted text

> If you want a real world testcase just: > > git clone git://github.com/hinrik/hailo.git > > Then add author_tests 'xt'; to the end of the Makefile.PL and run it. > It'll add two xt/*.t entries to the list of tests run.

Sun Feb 28 02:33:22 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Sun Feb 28 08:00:58 2010 rjbs [...] cpan.org - Correspondence added

So, in other words, Module::Install broke its downstream plugins. Presumably this affects ::ExtraTests, as well. Patches to fix them are welcome. -- rjbs

Sun Feb 28 08:01:05 2010 The RT System itself - Status changed from 'patched' to 'open'

Sun Feb 28 09:06:09 2010 ishigaki [...] cpan.org - Correspondence added

Thanks for the heads-up. Will send a patch after several other things are settled (may need some more tweaks on Module::Install side). On 2010-2-28 Sun 08:00:58, RJBS wrote: Show quoted text

> So, in other words, Module::Install broke its downstream plugins. > > Presumably this affects ::ExtraTests, as well. > > Patches to fix them are welcome.

Sun Feb 28 09:06:17 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Wed Mar 10 12:27:20 2010 ishigaki [...] cpan.org - Correspondence added

Hi. 0.95 is out. If you still have the problem, reopen this. Thanks.

Wed Mar 10 12:27:21 2010 The RT System itself - Status changed from 'patched' to 'open'

Wed Mar 10 12:27:21 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'