Skip Menu |

This queue is for tickets about the MooseX-Daemonize CPAN distribution.

Report information
The Basics
Id: 55013
Status: resolved
Priority: 0/
Queue: MooseX-Daemonize

People
Owner: ether [...] cpan.org
Requestors: alvar [...] a-blast.org
CHORNY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.15
Fixed in: 0.17



Subject: make test fails in win32 (Strawberry Perl)
Date: Fri, 26 Feb 2010 14:59:25 +0100
To: <bug-MooseX-Daemonize [...] rt.cpan.org>
From: Alvar Freude <alvar [...] a-blast.org>
Hi, on Win32 (Strawberry Perl) make test throws the following error: Running make test C:\Projekte\perl\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib\lib', 'blib\arch')" t/*.t t/00.load.t ................... 1/1 # Testing MooseX::Daemonize 0.09 t/00.load.t ................... ok t/01.filecreate.t ............. 1/29 t/01.filecreate.t ............. 17/29 # Failed test '... our pidfile exists' # at t/01.filecreate.t line 76. # Failed test '... the pid in our pidfile is correct (and not us)' # at t/01.filecreate.t line 79. # got: '4572' # expected: anything else # Failed test '... the daemon is running' # at t/01.filecreate.t line 81. # Failed test '... got the correct status message' # at t/01.filecreate.t line 82. # got: 'Daemon is not running with pid (4572)' # expected: 'Daemon is running with pid (4572)' # Failed test '... got the right error code' # at t/01.filecreate.t line 83. # got: '1' # expected: '0' # Failed test '... got the correct status message' # at t/01.filecreate.t line 98. # got: 'Not running' # expected: 'Stop succeeded' # Looks like you failed 6 tests of 29. And here it hangs, but can be canceled with ^C Ciao Alvar
I have no reason to believe that this module would ever work on Win32, it uses very specific *NIX behavior, however I may be wrong I am not that familiar with Perl on Win32. If you would like to provide patches to make this work under Win32, I would be happy to accept them. - Stevan
From: adam.boyers
Perhaps the installation (or at least the tests) could detect Windows and fail gracefully? Currently, attempting to install this module with Strawberry Perl results in a hung test script which must be aborted. I found this out because a module that purported to be cross-platform included MooseX::Daemonize as a dependency.
Path to correctly report that Windows is not supported. -- Alexandr Ciornii, http://chorny.net
Subject: Makefile.PL.patch
--- Makefile.PL.dist 2011-07-06 14:40:52.000000000 +0300 +++ Makefile.PL 2011-09-28 14:13:33.359375000 +0300 @@ -5,6 +5,8 @@ name 'MooseX-Daemonize'; all_from 'lib/MooseX/Daemonize.pm'; +die "OS unsupported" if $^O eq 'MSWin32'; + # Specific dependencies build_requires 'Test::More' => 0; build_requires 'Test::Moose' => 0;
From: raherh [...] gmail.com
On Fri Feb 26 10:47:30 2010, alvar@a-blast.org wrote: Show quoted text
> Hi, > > on Win32 (Strawberry Perl) make test throws the following error: > > > Running make test > C:\Projekte\perl\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'inc', 'blib\lib', 'blib\arch')" t/*.t > t/00.load.t ................... 1/1 # Testing MooseX::Daemonize 0.09 > t/00.load.t ................... ok > t/01.filecreate.t ............. 1/29 > t/01.filecreate.t ............. 17/29 # Failed test '... our pidfile > exists' > # at t/01.filecreate.t line 76. > > # Failed test '... the pid in our pidfile is correct (and not us)' > # at t/01.filecreate.t line 79. > # got: '4572' > # expected: anything else > > # Failed test '... the daemon is running' > # at t/01.filecreate.t line 81. > > # Failed test '... got the correct status message' > # at t/01.filecreate.t line 82. > # got: 'Daemon is not running with pid (4572)' > # expected: 'Daemon is running with pid (4572)' > > # Failed test '... got the right error code' > # at t/01.filecreate.t line 83. > # got: '1' > # expected: '0' > > # Failed test '... got the correct status message' > # at t/01.filecreate.t line 98. > # got: 'Not running' > # expected: 'Stop succeeded' > # Looks like you failed 6 tests of 29. > > > And here it hangs, but can be canceled with ^C > > > Ciao > Alvar >
I experience same behaviour on Solaris 10. Changing sleep(1) of t/01.filecreate.t to sleep(3) helps to pass this particular test. I had also to change sleep(1) to sleep(3) (line 34) of lib/Test/MooseX/ Daemonize.pm when running t/02.stdout.t because this test failed like this: not ok 1 - child forked okay # Failed test 'child forked okay' # at t/02.stdout.t line 46. # Pidfile (/tmp/3dqLY4ztYS/testoutput.pid) not found. ok 2 - No warnings from stop ok 3 - 2 output_ok ok 4 - 3 output_ok ok 5 - 4 output_ok 1..5 # Looks like you failed 1 test of 5. Radek
The consensus (among those who were awake) on #moose-dev was that this module should not be expected to run on MSWin32 at all. Consequently, I intend to put a line into Makefile.PL to mark this as uninstallable for that platform
Version 0.17 now explicitly prevents installation on MSWin32.