Skip Menu |

This queue is for tickets about the Video-FFmpeg CPAN distribution.

Report information
The Basics
Id: 55011
Status: resolved
Priority: 0/
Queue: Video-FFmpeg

People
Owner: RANDOMMAN [...] cpan.org
Requestors: Sergiy.Borodych [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.43
Fixed in: (no value)



Subject: some typos in FFmpeg.xs
I found some typos in FFmpeg.xs, so for me module not compile patch attached -- Sergiy Borodych
Subject: 0.43_FFmpeg.xs.diff
--- Video-FFmpeg-0.43.orig/FFmpeg.xs 2009-12-29 14:43:19.000000000 +0200 +++ Video-FFmpeg-0.43/FFmpeg.xs 2010-02-26 12:50:16.000000000 +0200 @@ -16,7 +16,7 @@ typedef struct AVStream Video_FFmpeg_AVS char* get_metadata(AVStream *st, const char* tag){ #if (LIBAVFORMAT_VERSION_MINOR > 44) || (LIBAVFORMAT_VERSION_MAJOR > 52) - AVMetadataTag *lang = av_metadata_get(st->metadata, "language", NULL, 0); + AVMetadataTag *lang = av_metadata_get(st->metadata, tag, NULL, 0); return lang->value; #else croak("Metadata requires libavformat 52.44 or greater\n"); @@ -25,7 +25,7 @@ char* get_metadata(AVStream *st, const c char* get_lang(AVStream *st){ #if (LIBAVFORMAT_VERSION_MINOR > 44) || (LIBAVFORMAT_VERSION_MAJOR > 52) - AVMetadataTag *lang = av_metadata_get(st->metadata, tag, NULL, 0); + AVMetadataTag *lang = av_metadata_get(st->metadata, "language", NULL, 0); return lang->value; #else return st->language;
Applied your patch and renamed some vars. Thanks Sergiy.