| Subject: | Doesn't pass perl critic test |
cpan[2]> install Catalyst::Model::Akismet
Running install for module 'Catalyst::Model::Akismet'
Running make for M/MR/MRAMBERG/Catalyst-Model-Akismet-0.03.tar.gz
Has already been unwrapped into directory
/root/.cpan/build/Catalyst-Model-Akismet-0.03-pkTzih
Has already been made
Running make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
t/00.load.t ........... 1/1 # Testing Catalyst::Model::Akismet 0.03
t/00.load.t ........... ok
t/01.functionality.t .. ok
t/02.perlcritic.t ..... 1/2
# Failed test 'Test::Perl::Critic for
"blib/lib/Catalyst/Helper/Model/Akismet.pm"'
# at /usr/share/perl5/site_perl/5.10.1/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in
"blib/lib/Catalyst/Helper/Model/Akismet.pm":
# Private Member Data shouldn't be accessed directly at line 54, column
13. Accessing an objects data directly breaks encapsulation and should
be avoided. Example: $object->{ some_key }. (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 57, column
13. Accessing an objects data directly breaks encapsulation and should
be avoided. Example: $object->{ some_key }. (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 61, column
5. Accessing an objects data directly breaks encapsulation and should
be avoided. Example: $object->{ some_key }. (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 62, column
16. Accessing an objects data directly breaks encapsulation and should
be avoided. Example: $object->{ some_key }. (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 63, column
16. Accessing an objects data directly breaks encapsulation and should
be avoided. Example: $object->{ some_key }. (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 66, column
43. Accessing an objects data directly breaks encapsulation and should
be avoided. Example: $object->{ some_key }. (Severity: 5)
# Looks like you failed 1 test of 2.
t/02.perlcritic.t ..... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests
t/03.pod.t ............ ok
t/04.pod-coverage.t ... ok
Test Summary Report
-------------------
t/02.perlcritic.t (Wstat: 256 Tests: 2 Failed: 1)
Failed test: 2
Non-zero exit status: 1
Files=5, Tests=10, 3 wallclock secs ( 0.02 usr 0.00 sys + 2.45 cusr
0.06 csys = 2.53 CPU)
Result: FAIL
Failed 1/5 test programs. 1/10 subtests failed.
make: *** [test_dynamic] Error 255
MRAMBERG/Catalyst-Model-Akismet-0.03.tar.gz
/usr/bin/make test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
reports MRAMBERG/Catalyst-Model-Akismet-0.03.tar.gz
Running make install
make test had returned bad status, won't install without force
Failed during this command:
MRAMBERG/Catalyst-Model-Akismet-0.03.tar.gz : make_test NO
Generally, I can notest install, but it would be great if the module did
actually install using standard method.