Skip Menu |

This queue is for tickets about the Net-IRR CPAN distribution.

Report information
The Basics
Id: 54973
Status: open
Priority: 0/
Queue: Net-IRR

People
Owner: Nobody in particular
Requestors: jmmills@cpan.org (no email address)
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.07
Fixed in: 0.07



Subject: Net::TCP requirement is antiquated.
Since it seems that Net-ext (provides Net::TCP) hasn't had a release in 8 years and IO::Socket is well maintained why not use IO::Socket? Attached is a simple patch that provides this support.
Subject: use_io_socket.patch
--- lib/Net/IRR.pm.orig 2010-02-25 03:06:52.229333080 -0800 +++ lib/Net/IRR.pm 2010-02-25 03:08:20.941344990 -0800 @@ -4,7 +4,7 @@ use warnings; use Carp; -use Net::TCP; +use IO::Socket::INET; use vars qw/ @ISA %EXPORT_TAGS @EXPORT_OK $VERSION /; @@ -32,8 +32,10 @@ $self->{port} = $args{port} || 43; eval { local $SIG{__WARN__} = sub { $self->{errstr} = shift }; - $self->{tcp} = Net::TCP->new($self->{host}, $self->{port}) - or warn "cannot create Net::TCP object: $!"; + $self->{tcp} = IO::Socket::INET->new( + PeerAddr => $self->{host}, + PeerPort => $self->{port} + ) or warn "cannot create Net::TCP object: $!"; }; return undef if $self->error(); $self->_multi_mode();
On Thu Feb 25 06:31:48 2010, JMMILLS wrote: Show quoted text
> Since it seems that Net-ext (provides Net::TCP) hasn't had a release in
8 Show quoted text
> years and IO::Socket is well maintained why not use IO::Socket? > Attached is a simple patch that provides this support.
Also, let me know if you would rather me rewrite this to support a "fancier" syntax I'm more than happy to help.
Subject: Re: [rt.cpan.org #54973] Net::TCP requirement is antiquated.
Date: Thu, 25 Feb 2010 07:28:37 -0800
To: bug-Net-IRR [...] rt.cpan.org
From: Todd Caine <todd.caine [...] gmail.com>
Thanks, Jason. I've actually just made this patch recently because I couldn't get Net::TCP to build on a new server running RHEL5. I've also needed to actually use this module again for the first time in 4 years and saw some missing functionality. Once I finish updating the POD, I will upload a new release. Appreciate the feedback, and couldn't agree with you more. I'll get something uploaded here soon. Regards, Todd On Thu, Feb 25, 2010 at 3:32 AM, Jason M. Mills via RT <bug-Net-IRR@rt.cpan.org> wrote: Show quoted text
>       Queue: Net-IRR >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=54973 > > > On Thu Feb 25 06:31:48 2010, JMMILLS wrote:
>> Since it seems that Net-ext (provides Net::TCP) hasn't had a release in
> 8
>> years and IO::Socket is well maintained why not use IO::Socket? >> Attached is a simple patch that provides this support.
> > Also, let me know if you would rather me rewrite this to support a > "fancier" syntax I'm more than happy to help. > >