Skip Menu |

This queue is for tickets about the MLDBM CPAN distribution.

Report information
The Basics
Id: 54911
Status: resolved
Priority: 0/
Queue: MLDBM
People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 2.02
Fixed in: 2.04

History Show all quoted text
  Tue Feb 23 11:22:39 2010 paul [...] city-fan.org - Ticket created
Subject: Test failure in t/storable_dbfile.t
I build RPM packages for a bunch of distribution releases and on some of the older ones, I get test failures in t/storable_dbfile.t: t/compare.t .......... ok t/dumper.t ........... ok t/freezethaw.t ....... skipped: (no reason given) t/storable.t ......... ok You tried to plan twice at t/storable_dbfile.t line 10. # Looks like your test exited with 2 before it could output anything. t/storable_dbfile.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 9/9 subtests I haven't narrowed it down to what exactly the key difference in environments is between successful and failed builds but the attached patch gets things working in all of the cases I tested.
Subject: perl-MLDBM-2.02-test.patch
--- MLDBM-2.02/t/storable_dbfile.t 2007-10-11 18:36:56.000000000 +0100 +++ MLDBM-2.02/t/storable_dbfile.t 2010-02-22 09:25:00.790737882 +0000 @@ -4,13 +4,15 @@ use MLDBM qw(DB_File Storable); use Data::Dumper; use strict; -use Test::More tests => 9; +use Test::More; + +eval { require Storable; require DB_File; }; +if ($@) { + plan skip_all => "Optional module (DB_File,Storable) not installed"; +} else { + plan tests => 9; +}; -plan skip_all => "Optional module (DB_File,Storable) not installed" - unless eval { - require Storable; - require DB_File; - }; tie my %o, 'MLDBM', 'testmldbm', O_CREAT|O_RDWR, 0640 or die $!; my $c_scalar = 'c';
  Tue Mar 02 11:11:31 2010 paul [...] city-fan.org - Correspondence added
From: paul [...] city-fan.org
On Tue Feb 23 11:22:39 2010, paul@city-fan.org wrote: Show quoted text
> I build RPM packages for a bunch of distribution releases and on some of > the older ones, I get test failures in t/storable_dbfile.t: > > t/compare.t .......... ok > t/dumper.t ........... ok > t/freezethaw.t ....... skipped: (no reason given) > t/storable.t ......... ok > You tried to plan twice at t/storable_dbfile.t line 10. > # Looks like your test exited with 2 before it could output anything. > t/storable_dbfile.t .. > Dubious, test returned 2 (wstat 512, 0x200) > Failed 9/9 subtests > > I haven't narrowed it down to what exactly the key difference in > environments is between successful and failed builds but the attached > patch gets things working in all of the cases I tested.
This issue is fixed in 2.03 but there's a new one appeared, at least if installing on a system with an old ExtUtils::MakeMaker: $ perl Makefile.PL INSTALLDIRS=vendor Checking if your kit is complete... Looks good Writing Makefile for MLDBM $ make perl "-Iblib/arch" "-Iblib/lib" Build.PL Build Can't locate Module/Build.pm in @INC (@INC contains: blib/arch blib/lib /usr/lib/perl5/5.8.5/i386-linux-thread-multi /usr/lib/perl5/5.8.5 /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.4/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.2/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.1/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi /usr/lib/perl5/site_perl/5.8.5 /usr/lib/perl5/site_perl/5.8.4 /usr/lib/perl5/site_perl/5.8.3 /usr/lib/perl5/site_perl/5.8.2 /usr/lib/perl5/site_perl/5.8.1 /usr/lib/perl5/site_perl/5.8.0 /usr/lib/perl5/site_perl /usr/lib/perl5/vendor_perl/5.8.5/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.4/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.3/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.2/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.1/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.0/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.5 /usr/lib/perl5/vendor_perl/5.8.4 /usr/lib/perl5/vendor_perl/5.8.3 /usr/lib/perl5/vendor_perl/5.8.2 /usr/lib/perl5/vendor_perl/5.8.1 /usr/lib/perl5/vendor_perl/5.8.0 /usr/lib/perl5/vendor_perl .) at Build.PL line 2. BEGIN failed--compilation aborted at Build.PL line 2. This looks a manifestation of RT#45111 but that should have been fixed with `Module::Build::Compat` version 0.33 and you've used 0.36 so I don't know how it's got into this state. However, this patch worked around the issue for me: --- MLDBM-2.03/Makefile.PL 2010-02-26 23:37:19.000000000 +0000 +++ MLDBM-2.03/Makefile.PL 2010-03-01 12:40:11.469691866 +0000 @@ -18,6 +18,7 @@ BUILD_REQUIRES => { 'Test::More' => 0, }, + 'PL_FILES' => {}, ); sub WriteMakefile1 { #Written by Alexandr Ciornii, version 0.21. Added by eumm-upgrade.
  Fri Sep 24 02:44:32 2010 CHORNY [...] cpan.org - Status changed from 'new' to 'resolved'
  Fri Sep 24 02:44:33 2010 CHORNY [...] cpan.org - Severity Important added
  Fri Sep 24 02:44:33 2010 CHORNY [...] cpan.org - Fixed in 2.04 added