Bug #54898 for PHP-Session: PHP::Session

Mon Feb 22 21:47:40 2010 stanton [...] electric-cloud.com - Ticket created

Subject:	PHP::Session
Date:	Tue, 23 Feb 2010 02:43:15 +0000
To:	"bug-PHP-Session [...] rt.cpan.org" <bug-PHP-Session [...] rt.cpan.org>
From:	Scott Stanton <stanton [...] electric-cloud.com>

I am trying to use the PHP::Session package and have run into a few issues trying to update a session file: * On Windows, the save() function is not setting binmode(), so text that contains newlines results in a corrupted session file. * The order of elements in PHP arrays is not preserved. * String data that looks like a floating point number is being converted to a float and then saved as a number, losing the string formatting. For example, a string value of "1.0" gets saved as a floating point "1.0", which php will turn into "1" on reload, losing the formatted representation. I have patches for all of these issues that I would like to contribute back. My changes are: * Use binmode in save() * Use Tie::IxHash to preserve the ordering of array elements * Added a configuration option to suppress conversions to numeric types I have attached a patch against 0.27 that I hope you will consider including in a new version. Please let me know if you have any questions. --Scott

Message body is not shown because sender requested not to inline it.

Mon Feb 22 21:58:37 2010 miyagawa [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #54898] PHP::Session
Date:	Mon, 22 Feb 2010 18:57:37 -0800
To:	bug-PHP-Session [...] rt.cpan.org
From:	Tatsuhiko Miyagawa <miyagawa [...] gmail.com>

Hi, Do you have a PAUSE ID? I can give you a comaint if you'd like to maintain the module, which I don't do anymore. Also, the repository is at http://github.com/miyagawa/php-session so you can fork. On Mon, Feb 22, 2010 at 6:47 PM, Scott Stanton via RT <bug-PHP-Session@rt.cpan.org> wrote: Show quoted text

> Mon Feb 22 21:47:40 2010: Request 54898 was acted upon. > Transaction: Ticket created by snstanton > Queue: PHP-Session > Subject: PHP::Session > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: stanton@electric-cloud.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > > > > I am trying to use the PHP::Session package and have run into a few issues trying to update a session file: > > > * On Windows, the save() function is not setting binmode(), so text that contains newlines results in a corrupted session file. > > * The order of elements in PHP arrays is not preserved. > > * String data that looks like a floating point number is being converted to a float and then saved as a number, losing the string formatting. For example, a string value of "1.0" gets saved as a floating point "1.0", which php will turn into "1" on reload, losing the formatted representation. > > I have patches for all of these issues that I would like to contribute back. My changes are: > > > * Use binmode in save() > > * Use Tie::IxHash to preserve the ordering of array elements > > * Added a configuration option to suppress conversions to numeric types > > I have attached a patch against 0.27 that I hope you will consider including in a new version. Please let me know if you have any questions. > > --Scott > > >

-- Tatsuhiko Miyagawa

Mon Feb 22 21:58:40 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Feb 23 13:40:45 2010 stanton [...] electric-cloud.com - Correspondence added

Subject:	RE: [rt.cpan.org #54898] PHP::Session
Date:	Tue, 23 Feb 2010 18:39:33 +0000
To:	"bug-PHP-Session [...] rt.cpan.org" <bug-PHP-Session [...] rt.cpan.org>
From:	Scott Stanton <stanton [...] electric-cloud.com>

My PAUSE ID is SNSTANTON. Thanks! --Scott Show quoted text

-----Original Message----- From: miyagawa@gmail.com via RT [mailto:bug-PHP-Session@rt.cpan.org] Sent: Monday, February 22, 2010 6:59 PM To: Scott Stanton Subject: Re: [rt.cpan.org #54898] PHP::Session <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > Hi, Do you have a PAUSE ID? I can give you a comaint if you'd like to maintain the module, which I don't do anymore. Also, the repository is at http://github.com/miyagawa/php-session so you can fork. On Mon, Feb 22, 2010 at 6:47 PM, Scott Stanton via RT <bug-PHP-Session@rt.cpan.org> wrote:

> Mon Feb 22 21:47:40 2010: Request 54898 was acted upon. > Transaction: Ticket created by snstanton > Queue: PHP-Session > Subject: PHP::Session > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: stanton@electric-cloud.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > > > > I am trying to use the PHP::Session package and have run into a few issues trying to update a session file: > > > * On Windows, the save() function is not setting binmode(), so text that contains newlines results in a corrupted session file. > > * The order of elements in PHP arrays is not preserved. > > * String data that looks like a floating point number is being converted to a float and then saved as a number, losing the string formatting. For example, a string value of "1.0" gets saved as a floating point "1.0", which php will turn into "1" on reload, losing the formatted representation. > > I have patches for all of these issues that I would like to contribute back. My changes are: > > > * Use binmode in save() > > * Use Tie::IxHash to preserve the ordering of array elements > > * Added a configuration option to suppress conversions to numeric types > > I have attached a patch against 0.27 that I hope you will consider including in a new version. Please let me know if you have any questions. > > --Scott > > >

-- Tatsuhiko Miyagawa

Tue Mar 16 13:21:33 2010 stanton [...] electric-cloud.com - Correspondence added

CC:	"miyagawa [...] gmail.com" <miyagawa [...] gmail.com>
Subject:	RE: [rt.cpan.org #54898] PHP::Session
Date:	Tue, 16 Mar 2010 17:20:10 +0000
To:	"bug-PHP-Session [...] rt.cpan.org" <bug-PHP-Session [...] rt.cpan.org>
From:	Scott Stanton <stanton [...] electric-cloud.com>

I didn't hear a response, so I'm guessing it got filtered. My PAUSE ID is SNSTANTON. Show quoted text

-----Original Message----- From: miyagawa@gmail.com via RT [mailto:bug-PHP-Session@rt.cpan.org] Sent: Monday, February 22, 2010 6:59 PM To: Scott Stanton Subject: Re: [rt.cpan.org #54898] PHP::Session <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > Hi, Do you have a PAUSE ID? I can give you a comaint if you'd like to maintain the module, which I don't do anymore. Also, the repository is at http://github.com/miyagawa/php-session so you can fork. On Mon, Feb 22, 2010 at 6:47 PM, Scott Stanton via RT <bug-PHP-Session@rt.cpan.org> wrote:

> Mon Feb 22 21:47:40 2010: Request 54898 was acted upon. > Transaction: Ticket created by snstanton > Queue: PHP-Session > Subject: PHP::Session > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: stanton@electric-cloud.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > > > > I am trying to use the PHP::Session package and have run into a few issues trying to update a session file: > > > * On Windows, the save() function is not setting binmode(), so text that contains newlines results in a corrupted session file. > > * The order of elements in PHP arrays is not preserved. > > * String data that looks like a floating point number is being converted to a float and then saved as a number, losing the string formatting. For example, a string value of "1.0" gets saved as a floating point "1.0", which php will turn into "1" on reload, losing the formatted representation. > > I have patches for all of these issues that I would like to contribute back. My changes are: > > > * Use binmode in save() > > * Use Tie::IxHash to preserve the ordering of array elements > > * Added a configuration option to suppress conversions to numeric types > > I have attached a patch against 0.27 that I hope you will consider including in a new version. Please let me know if you have any questions. > > --Scott > > >

-- Tatsuhiko Miyagawa

Tue Mar 16 15:17:04 2010 miyagawa [...] gmail.com - Correspondence added

CC:	"bug-PHP-Session [...] rt.cpan.org" <bug-PHP-Session [...] rt.cpan.org>
Subject:	Re: [rt.cpan.org #54898] PHP::Session
Date:	Tue, 16 Mar 2010 12:16:00 -0700
To:	Scott Stanton <stanton [...] electric-cloud.com>
From:	Tatsuhiko Miyagawa <miyagawa [...] gmail.com>

It's not -- sorry but i won't give away modules to authors without any modules. On Tue, Mar 16, 2010 at 10:20 AM, Scott Stanton <stanton@electric-cloud.com> wrote: Show quoted text

> I didn't hear a response, so I'm guessing it got filtered. My PAUSE ID is SNSTANTON. > > -----Original Message----- > From: miyagawa@gmail.com via RT [mailto:bug-PHP-Session@rt.cpan.org] > Sent: Monday, February 22, 2010 6:59 PM > To: Scott Stanton > Subject: Re: [rt.cpan.org #54898] PHP::Session > > <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > > > Hi, > > Do you have a PAUSE ID? I can give you a comaint if you'd like to > maintain the module, which I don't do anymore. Also, the repository is > at http://github.com/miyagawa/php-session so you can fork. > > > On Mon, Feb 22, 2010 at 6:47 PM, Scott Stanton via RT > <bug-PHP-Session@rt.cpan.org> wrote:

>> Mon Feb 22 21:47:40 2010: Request 54898 was acted upon. >> Transaction: Ticket created by snstanton >> Queue: PHP-Session >> Subject: PHP::Session >> Broken in: (no value) >> Severity: (no value) >> Owner: Nobody >> Requestors: stanton@electric-cloud.com >> Status: new >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > >> >> >> I am trying to use the PHP::Session package and have run into a few issues trying to update a session file: >> >> >> * On Windows, the save() function is not setting binmode(), so text that contains newlines results in a corrupted session file. >> >> * The order of elements in PHP arrays is not preserved. >> >> * String data that looks like a floating point number is being converted to a float and then saved as a number, losing the string formatting. For example, a string value of "1.0" gets saved as a floating point "1.0", which php will turn into "1" on reload, losing the formatted representation. >> >> I have patches for all of these issues that I would like to contribute back. My changes are: >> >> >> * Use binmode in save() >> >> * Use Tie::IxHash to preserve the ordering of array elements >> >> * Added a configuration option to suppress conversions to numeric types >> >> I have attached a patch against 0.27 that I hope you will consider including in a new version. Please let me know if you have any questions. >> >> --Scott >> >> >>

> > > > -- > Tatsuhiko Miyagawa > >

-- Tatsuhiko Miyagawa

Tue Mar 16 16:19:27 2010 stanton [...] electric-cloud.com - Correspondence added

CC:	"bug-PHP-Session [...] rt.cpan.org" <bug-PHP-Session [...] rt.cpan.org>
Subject:	RE: [rt.cpan.org #54898] PHP::Session
Date:	Tue, 16 Mar 2010 20:18:31 +0000
To:	Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
From:	Scott Stanton <stanton [...] electric-cloud.com>

Well, I do have commit privileges on the PAR and PAR::Packer svn repositories for whatever that's worth. However, all I really wanted was to get these patches applied so I don't have to maintain a separate distribution of PHP::Session. --Scott Show quoted text

-----Original Message----- From: Tatsuhiko Miyagawa [mailto:miyagawa@gmail.com] Sent: Tuesday, March 16, 2010 12:16 PM To: Scott Stanton Cc: bug-PHP-Session@rt.cpan.org Subject: Re: [rt.cpan.org #54898] PHP::Session It's not -- sorry but i won't give away modules to authors without any modules. On Tue, Mar 16, 2010 at 10:20 AM, Scott Stanton <stanton@electric-cloud.com> wrote:

> I didn't hear a response, so I'm guessing it got filtered. My PAUSE ID is SNSTANTON. > > -----Original Message----- > From: miyagawa@gmail.com via RT [mailto:bug-PHP-Session@rt.cpan.org] > Sent: Monday, February 22, 2010 6:59 PM > To: Scott Stanton > Subject: Re: [rt.cpan.org #54898] PHP::Session > > <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > > > Hi, > > Do you have a PAUSE ID? I can give you a comaint if you'd like to > maintain the module, which I don't do anymore. Also, the repository is > at http://github.com/miyagawa/php-session so you can fork. > > > On Mon, Feb 22, 2010 at 6:47 PM, Scott Stanton via RT > <bug-PHP-Session@rt.cpan.org> wrote:

>> Mon Feb 22 21:47:40 2010: Request 54898 was acted upon. >> Transaction: Ticket created by snstanton >> Queue: PHP-Session >> Subject: PHP::Session >> Broken in: (no value) >> Severity: (no value) >> Owner: Nobody >> Requestors: stanton@electric-cloud.com >> Status: new >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=54898 > >> >> >> I am trying to use the PHP::Session package and have run into a few issues trying to update a session file: >> >> >> * On Windows, the save() function is not setting binmode(), so text that contains newlines results in a corrupted session file. >> >> * The order of elements in PHP arrays is not preserved. >> >> * String data that looks like a floating point number is being converted to a float and then saved as a number, losing the string formatting. For example, a string value of "1.0" gets saved as a floating point "1.0", which php will turn into "1" on reload, losing the formatted representation. >> >> I have patches for all of these issues that I would like to contribute back. My changes are: >> >> >> * Use binmode in save() >> >> * Use Tie::IxHash to preserve the ordering of array elements >> >> * Added a configuration option to suppress conversions to numeric types >> >> I have attached a patch against 0.27 that I hope you will consider including in a new version. Please let me know if you have any questions. >> >> --Scott >> >> >>

> > > > -- > Tatsuhiko Miyagawa > >

-- Tatsuhiko Miyagawa