Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the HTML-Tidy CPAN distribution.

Report information
The Basics
Id: 54865
Status: resolved
Priority: 0/
Queue: HTML-Tidy

People
Owner: Nobody in particular
Requestors: kmx [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: #include <tidy.h> vs <tidyp.h>
Hi,

in  HTML-Tidy-1.50 / Tidy.xs you are still using #include <tidy.h> despite the fact that it seems you have switched from the old "libtidy" to your "libtidyp".

So perhaps
- #include <tidy.h>
+ #include <tidyp.h>

--
kmx
From: paul [...] city-fan.org
This patch that I have used also updates Makefile.PL to take into account the name change.
Subject: HTML-Tidy-1.50-libtidyp.patch
--- HTML-Tidy-1.50/Makefile.PL 2010-02-16 17:40:14.000000000 +0000 +++ HTML-Tidy-1.50/Makefile.PL 2010-02-22 12:15:59.700420320 +0000 @@ -8,22 +8,22 @@ use ExtUtils::MakeMaker; use ExtUtils::Liblist; -my @vars = ExtUtils::Liblist->ext( '-ltidy', 0, 1 ); +my @vars = ExtUtils::Liblist->ext( '-ltidyp', 0, 1 ); my $libs = $vars[2]; if ( !$libs ) { - $libs = '-ltidy'; + $libs = '-ltidyp'; print <<'EOF'; -It seems that you don't have libtidy installed. HTML::Tidy does no -real work on its own. It's just a wrapper aound libtidy. +It seems that you don't have libtidyp installed. HTML::Tidy does no +real work on its own. It's just a wrapper aound libtidyp. -HTML::Tidy is only tested to work with libtidy hosted at -http://github.com/petdance/libtidy. This is mostly the same as the one +HTML::Tidy is only tested to work with libtidyp hosted at +http://github.com/petdance/libtidyp. This is mostly the same as the one at http://tidy.sourceforge.net/, with some changes, such as adding a version number so that we can tell what version we're working with. -If you do have libtidy installed, and I just haven't detected it, +If you do have libtidyp installed, and I just haven't detected it, go ahead and try building. If HTML::Tidy builds and tests correctly, then please let Andy Lester know at andy@petdance.com so that he can fix the library detection code. @@ -58,7 +58,7 @@ LIBS => [$libs], NEEDS_LINKING => 1, - INC => '-I. -I/usr/include/tidy -I/usr/local/include/tidy -I/sw/include/tidy', + INC => '-I. -I/usr/include/tidyp -I/usr/local/include/tidyp -I/sw/include/tidyp', EXE_FILES => [qw(bin/webtidy)], dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', }, --- HTML-Tidy-1.50/Tidy.xs 2010-02-16 17:43:56.000000000 +0000 +++ HTML-Tidy-1.50/Tidy.xs 2010-02-22 12:16:34.076535824 +0000 @@ -2,7 +2,7 @@ #include "perl.h" #include "XSUB.h" -#include <tidy.h> +#include <tidyp.h> #include <buffio.h> #include <stdio.h> #include <errno.h>
All of this is cleared up in the next release.