Bug #54863 for C-Scan: on windows

Mon Feb 22 01:46:30 2010 JeanDamienDurand [...] free.fr - Ticket created

Subject:	on windows
Date:	Mon, 22 Feb 2010 07:45:37 +0100
To:	bug-C-Scan [...] rt.cpan.org
From:	"Jean-Damien Durand" <JeanDamienDurand [...] free.fr>

C::Scan 0.74 OS : Windows Distribution : Strawberry Perl version : This is perl, v5.10.1 (*) built for MSWin32-x86-multi-thread On Windows the echo command will natively consider a character to echo. For that OS, the cmd command when piping to the compiler could look like this 847,852c847 < my $cmd; < if ($^O =~ /win32/i) { < $cmd = "echo #include \"$filename\"| $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; < } else { < $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; < } --- Show quoted text

> my $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |";

Thanks, Regards, Jean-Damien.

Wed Mar 03 17:47:51 2010 nospam-abuse [...] ilyaz.org - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #54863] on windows
Date:	Wed, 3 Mar 2010 14:46:56 -0800
To:	Jean-Damien Durand via RT <bug-C-Scan [...] rt.cpan.org>
From:	Ilya Zakharevich <nospam-abuse [...] ilyaz.org>

On Mon, Feb 22, 2010 at 01:46:31AM -0500, Jean-Damien Durand via RT wrote: Show quoted text

> On Windows the echo command will natively consider a character to echo.

Wrong. Show quoted text

> For that OS, the cmd command when piping to the compiler could look like this

This is not OS-dependent, just shell-dependent. Show quoted text

> 847,852c847 > < my $cmd; > < if ($^O =~ /win32/i) { > < $cmd = "echo #include \"$filename\"| $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; > < } else { > < $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; > < } > ---

> > my $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |";

This is inverted, and useless (not context diff). I prefer using diff -pu ..... Anyway, are you ABSOLUTELY sure that /win32/i is the correct way to detect that the shell used by Perl is not Bourne? This looks so frustrating; I even think about using system qq(echo "1" | $^X -wne "exit 1 unless /\\x22/") and print q(no quote)" ... :-( Yours, Ilya P.S. I'm also asking this on c.l.p.m...

Wed Mar 03 17:47:53 2010 The RT System itself - Status changed from 'new' to 'open'

Sun Mar 07 16:52:55 2010 nospam-abuse [...] ilyaz.org - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #54863] on windows
Date:	Sun, 7 Mar 2010 13:51:55 -0800
To:	Jean-Damien Durand via RT <bug-C-Scan [...] rt.cpan.org>
From:	Ilya Zakharevich <nospam-abuse [...] ilyaz.org>

On Mon, Feb 22, 2010 at 01:46:31AM -0500, Jean-Damien Durand via RT wrote: Show quoted text

> C::Scan 0.74 > OS : Windows > Distribution : Strawberry > Perl version : This is perl, v5.10.1 (*) built for MSWin32-x86-multi-thread > > On Windows the echo command will natively consider a character to echo. > For that OS, the cmd command when piping to the compiler could look like this > > 847,852c847 > < my $cmd; > < if ($^O =~ /win32/i) { > < $cmd = "echo #include \"$filename\"| $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; > < } else { > < $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; > < } > ---

> > my $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |";

Could you try the attached patch, and report? Thanks, Ilya

Message body is not shown because sender requested not to inline it.

Mon Jul 25 11:27:19 2011 feratilbeau [...] hotmail.com - Correspondence added

From:

feratilbeau [...] hotmail.com

Ilya, Sorry for this huge delay. Indeed, it works fine on Windows with this patch -; Thanks a lot, Best Regards, Jean-Damien.

Tue Aug 04 05:29:28 2015 BULKDD [...] cpan.org - Correspondence added

RT-Send-CC:

nospam-abuse [...] ilyaz.org, feratilbeau [...] hotmail.com

On Mon Feb 22 01:46:30 2010, JeanDamienDurand@free.fr wrote: Show quoted text

> C::Scan 0.74 > OS : Windows > Distribution : Strawberry > Perl version : This is perl, v5.10.1 (*) built for MSWin32-x86-multi- > thread > > On Windows the echo command will natively consider a character to > echo. > For that OS, the cmd command when piping to the compiler could look > like this > > 847,852c847 > < my $cmd; > < if ($^O =~ /win32/i) { > < $cmd = "echo #include \"$filename\"| $Cpp->{cppstdin} $Defines > $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; > < } else { > < $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} > $Defines $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |"; > < } > ---

> > my $cmd = "echo '\#include \"$filename\"' | $Cpp->{cppstdin} $Defines > > $addincludes $Cpp->{cppflags} $Cpp->{cppminus} |";

> > Thanks, > > Regards, Jean-Damien.

Report of this bug in the wild https://rt.perl.org/Ticket/Display.html?id=125720