Skip Menu |

This queue is for tickets about the Text-RecordParser CPAN distribution.

Report information
The Basics
Id: 54816
Status: open
Priority: 0/
Queue: Text-RecordParser

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 1.4.0
  • v1.5.0
Fixed in: (no value)



Subject: test uses perl from path instead of $^X
The test t/13-tab2graph.t calls bin/tab2graph. This contains a shebang #!/usr/bin/env perl which calls the first perl in the PATH. If this perl has no GraphViz installed then the test fails. The following pseud patch fixes this: - my $command = "$TAB2GRAPH -c -o $out_file $data 2>&1"; + my $command = "\"$^X\" $TAB2GRAPH -c -o $out_file $data 2>&1"; Thanks,
On 2010-02-19 23:21:16, ANDK wrote: Show quoted text
> The test t/13-tab2graph.t calls bin/tab2graph. This contains a shebang > > #!/usr/bin/env perl > > which calls the first perl in the PATH. If this perl has no GraphViz > installed then the test fails. > > The following pseud patch fixes this: > > - my $command = "$TAB2GRAPH -c -o $out_file $data 2>&1"; > + my $command = "\"$^X\" $TAB2GRAPH -c -o $out_file $data 2>&1"; >
This still fails with recent versions (v1.6.3). I think a better fix is to change the shebang in all scripts in bin to just "#!perl", so ExtUtils::MakeMaker or Module::Build handle the correct shebang replacement, and to use the script as installed in blib/scripts for testing.