Skip Menu |

This queue is for tickets about the Net-OpenSSH-Parallel CPAN distribution.

Report information
The Basics
Id: 54749
Status: resolved
Worked: 45 min
Priority: 0/
Queue: Net-OpenSSH-Parallel

People
Owner: salva [...] cpan.org
Requestors: XSAWYERX [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] scp_put not working
Currently scp_put() is broken. The reason is that _start_scp_put expects two variables before the files: $label and $opts. However, you're not allowed to send $opts, so even if you try to feed it an empty hashref, it will fail much earlier. The fix is to to expect only $label, and declare $opts an empty hashref. A long-term fix, perhaps, would be to allow a hashref and check if it is indeed a hashref.
Subject: fix_scp.patch
--- /usr/local/share/perl/5.10.0/Net/OpenSSH/Parallel.pm 2010-02-18 14:23:28.189677559 +0200 +++ lib/Net/OpenSSH/Parallel.pm 2010-02-18 14:26:51.182556461 +0200 @@ -530,7 +530,7 @@ sub _start_scp_put { my $self = shift; my $label = shift; - my $opts = shift; + my $opts = {}; my $host = $self->{hosts}{$label}; my $ssh = $host->{ssh}; $debug and _debug(action => "[$label] start scp_put action");
On Thu Feb 18 07:31:37 2010, xsawyerx wrote: Show quoted text
> Currently scp_put() is broken. The reason is that _start_scp_put expects > two variables before the files: $label and $opts. However, you're not > allowed to send $opts, so even if you try to feed it an empty hashref, > it will fail much earlier. > > The fix is to to expect only $label, and declare $opts an empty hashref. > > A long-term fix, perhaps, would be to allow a hashref and check if it is > indeed a hashref.
Solved in 0.05 available from CPAN