Skip Menu |

This queue is for tickets about the local-lib CPAN distribution.

Report information
The Basics
Id: 54743
Status: resolved
Priority: 0/
Queue: local-lib

People
Owner: Nobody in particular
Requestors: marcoep [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.004009
Fixed in: (no value)



Subject: Annoying warnings when ENV is incomplete
Hello, When running with an incomplete ENV (e.g. via a SVN hook as in my case), PATH and PERL5LIB might not be defined, which causes warnings. Patch attached. Best, Marco
Subject: lib.pm.patch
*** lib.pm.orig 2010-02-18 10:25:36.713980000 +0100 --- lib.pm 2010-02-18 10:25:36.691048000 +0100 *************** *** 350,366 **** PERL5LIB => join($Config{path_sep}, $class->install_base_perl_path($path), $class->install_base_arch_path($path), ! ($ENV{PERL5LIB} ? ! ($interpolate == INTERPOLATE_ENV ! ? ($ENV{PERL5LIB}) ! : (($^O ne 'MSWin32') ? '$PERL5LIB' : '%PERL5LIB%' )) ! : ()) ), PATH => join($Config{path_sep}, $class->install_base_bin_path($path), ! ($interpolate == INTERPOLATE_ENV ! ? $ENV{PATH} ! : (($^O ne 'MSWin32') ? '$PATH' : '%PATH%' )) ), ) } --- 350,372 ---- PERL5LIB => join($Config{path_sep}, $class->install_base_perl_path($path), $class->install_base_arch_path($path), ! ( ! $ENV{PERL5LIB} ? ! ( ! $interpolate == INTERPOLATE_ENV ? ! ($ENV{PERL5LIB} || ()) ! : ( ($^O ne 'MSWin32') ? '$PERL5LIB' : '%PERL5LIB%' ) ! ) ! : () ! ) ), PATH => join($Config{path_sep}, $class->install_base_bin_path($path), ! ( ! $interpolate == INTERPOLATE_ENV ? ! ($ENV{PATH} || ()) ! : (($^O ne 'MSWin32') ? '$PATH' : '%PATH%' ) ! ) ), ) }
This patch doesn't apply. I'll take a look at what it's trying to do and work out what to do later today. Of course, if you send me a working patch, I can commit this earlier... ;)
From: marcoep [...] gmail.com
Oops, sorry for that. I generated the patch the wrong way. The new one should work. BTW, it's just a matter of having these ($ENV{PERL5LIB} || ()) ($ENV{PATH} || ()) in the relevant places of build_environment_vars_for(), instead of plain $ENV{PERL5LIB} $ENV{PATH} Cheers, Marco
Subject: lib.pm.patch
*** lib.pm 2010-02-18 11:26:48.499425000 +0100 --- lib.pm.new 2010-02-18 11:25:07.835481000 +0100 *************** *** 350,366 **** PERL5LIB => join($Config{path_sep}, $class->install_base_perl_path($path), $class->install_base_arch_path($path), ! ($ENV{PERL5LIB} ? ! ($interpolate == INTERPOLATE_ENV ! ? ($ENV{PERL5LIB}) ! : (($^O ne 'MSWin32') ? '$PERL5LIB' : '%PERL5LIB%' )) ! : ()) ), PATH => join($Config{path_sep}, $class->install_base_bin_path($path), ! ($interpolate == INTERPOLATE_ENV ! ? $ENV{PATH} ! : (($^O ne 'MSWin32') ? '$PATH' : '%PATH%' )) ), ) } --- 350,372 ---- PERL5LIB => join($Config{path_sep}, $class->install_base_perl_path($path), $class->install_base_arch_path($path), ! ( ! $ENV{PERL5LIB} ? ! ( ! $interpolate == INTERPOLATE_ENV ? ! ($ENV{PERL5LIB} || ()) ! : ( ($^O ne 'MSWin32') ? '$PERL5LIB' : '%PERL5LIB%' ) ! ) ! : () ! ) ), PATH => join($Config{path_sep}, $class->install_base_bin_path($path), ! ( ! $interpolate == INTERPOLATE_ENV ? ! ($ENV{PATH} || ()) ! : (($^O ne 'MSWin32') ? '$PATH' : '%PATH%' ) ! ) ), ) }
Fixed in r8738. Thanks!