Skip Menu |

This queue is for tickets about the Moose CPAN distribution.

Report information
The Basics
Id: 54478
Status: resolved
Priority: 0/
Queue: Moose

People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.97
Fixed in: (no value)



Subject: tabs present in some tests
I have a version of Test::NoTabs patched for RT#53727 (Tab detection breaks with malformed POD), and using this version with the "tabs" test in Moose 0.97 reveals a couple of test files that have tabs in them. Attached patch removes the tabs and fixes a typo for good measure.
Subject: Test-NoTabs-0.9-warning.patch
--- Test-NoTabs-0.9/lib/Test/NoTabs.pm 2009-07-03 09:33:34.000000000 +0100 +++ Test-NoTabs-0.9/lib/Test/NoTabs.pm 2010-02-10 09:55:13.385054303 +0000 @@ -98,7 +98,7 @@ my $file = shift; return 1 if $file =~ /\.pl$/i; return 1 if $file =~ /\.t$/; - open my $fh, $file or return; + open (my $fh, $file) or return; my $first = <$fh>; return 1 if defined $first && ($first =~ $PERL_PATTERN); return;
On Wed Feb 10 08:25:24 2010, paul@city-fan.org wrote: Show quoted text
> Attached patch removes the tabs and fixes a typo for good measure.
Apparently you attached the wrong patch.
From: paul [...] city-fan.org
On Thu Mar 11 23:05:57 2010, FLORA wrote: Show quoted text
> On Wed Feb 10 08:25:24 2010, paul@city-fan.org wrote:
> > Attached patch removes the tabs and fixes a typo for good measure.
> > Apparently you attached the wrong patch.
Whoops, so I did. The tabs were fixed in Moose 0.99 anyway but the typo remains, a mis-spelling of "constraint" at line 26 of t/040_type_constraints/030_class_subtypes.t.