| Subject: | `Parentheses missing around "my" list' warning in old Perls |
Running the "Moose" test suite on some old Fedora distributions (e.g.
Fedora 1 with perl 5.8.3, though the issue might manifest in more recent
versions too - I didn't check) results in a warning that points at
Test::NoTabs about `Parentheses missing around "my" list' at line 101 of
Test/NoTabs.pm. The attached patch adds the parentheses and quietens the
warning, without any side effects that I could see.
| Subject: | Test-NoTabs-0.9-warning.patch |
--- Test-NoTabs-0.9/lib/Test/NoTabs.pm 2009-07-03 09:33:34.000000000 +0100
+++ Test-NoTabs-0.9/lib/Test/NoTabs.pm 2010-02-10 09:55:13.385054303 +0000
@@ -98,7 +98,7 @@
my $file = shift;
return 1 if $file =~ /\.pl$/i;
return 1 if $file =~ /\.t$/;
- open my $fh, $file or return;
+ open (my $fh, $file) or return;
my $first = <$fh>;
return 1 if defined $first && ($first =~ $PERL_PATTERN);
return;