Skip Menu |

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 54390
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: ansgar [...] 43-1.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] correct spelling errors
Date: Mon, 08 Feb 2010 01:11:23 +0900
To: bug-XML-LibXML [...] rt.cpan.org
From: Ansgar Burchardt <ansgar [...] 43-1.org>
Hi, the attached patches were introduced to correct several spelling errors. Please consider applying them. Regards, Ansgar
Description: Fix a typo in an error message. Author: Adam Buchbinder <adam.buchbinder@gmail.com> --- a/LibXML.pm +++ b/LibXML.pm @@ -1557,7 +1557,7 @@ } if (defined($nsURI) and $nsURI eq XML_XMLNS_NS) { if ($qname !~ /^xmlns(?::|$)/) { - croak("NAMESPACE ERROR: Namespace declartions must have the prefix 'xmlns'"); + croak("NAMESPACE ERROR: Namespace declarations must have the prefix 'xmlns'"); } $self->setAttribute($qname,$value); # see implementation above return;
Description: Fix some typos in the POD/man page --- a/lib/XML/LibXML/Node.pod +++ b/lib/XML/LibXML/Node.pod @@ -20,7 +20,7 @@ $oldnode = $node->replaceChild( $newNode, $oldNode ); $node->replaceNode($newNode); $childnode = $node->appendChild( $childnode ); - $childnode = $node->addChild( $chilnode ); + $childnode = $node->addChild( $childnode ); $node = $parent->addNewChild( $nsURI, $name ); $node->addSibling($newNode); $newnode =$node->cloneNode( $deep ); @@ -150,7 +150,7 @@ $node->unbindNode(); Unbinds the Node from its siblings and Parent, but not from the Document it -belongs to. If the node is not inserted into the DOM afterwards it will be lost +belongs to. If the node is not inserted into the DOM afterwards, it will be lost after the program terminated. From a low level view, the unbound node is stripped from the context it is and inserted into a (hidden) document-fragment. @@ -388,7 +388,7 @@ @nodes = $node->findnodes( $xpath_expression ); I<<<<<< findnodes >>>>>> evaluates the xpath expression (XPath 1.0) on the current node and returns the -resulting node set as an array. In scalar context returns a L<<<<<< XML::LibXML::NodeList >>>>>> object. +resulting node set as an array. In a scalar context returns a L<<<<<< XML::LibXML::NodeList >>>>>> object. The xpath expression can be passed either as a string or or as a L<<<<<< XML::LibXML::XPathExpression >>>>>> object.
Hi Ansgar, On Sun Feb 07 11:12:32 2010, ansgar@43-1.org wrote: Show quoted text
> Hi, > > the attached patches were introduced to correct several spelling > errors. Please consider applying them. > > Regards, > Ansgar
Thanks for the patches. I applied most of them manually, except for the "In scalar context" -> "In a scalar context" one, because in idiomatic speech one can say "in scalar context". On the other hand, I added some commas after the "In scalar context" and in other places. This is now in the repository and will be in the next CPAN release. Regards, -- Shlomi Fish