Skip Menu |

This queue is for tickets about the Perl-Metrics-Simple CPAN distribution.

Report information
The Basics
Id: 54293
Status: resolved
Estimated: 3 hours (180 min)
Worked: 1.5 hours (90 min)
Priority: 0/
Queue: Perl-Metrics-Simple

People
Owner: matisse [...] spamcop.net
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.13
Fixed in: 0.14



Subject: existing PPI::Document
I'd like to have ability to work on existing PPI::Document. For ex., Padre IDE already has created PPI::Document, so it would be faster. -- Alexandr Ciornii, http://chorny.net
Interesting idea. Thanks for the suggestion. Can you provide one or two examples of how you would actually use the new feature? I'd like to see those before I make up something that might not be as useful for you.
Feb 04 10:35:29 2010, MATISSE wrote Show quoted text
> Interesting idea. Thanks for the suggestion. > > Can you provide one or two examples of how you would actually use the > new feature? > I'd like to see those before I make up something that might not be as > useful for you.
IMHO, best would be to let Perl::Metrics::Simple accept either text in form of scalar ref (as PPI::Document does) or PPI::Document object. Patch attached, with several other small changes. -- Alexandr Ciornii, http://chorny.net
Subject: Perl-Metrics-Simple-patch.rar
Download Perl-Metrics-Simple-patch.rar
application/octetstream 7.8k

Message body not shown because it is not plain text.

Also in .zip, in case you don't have RAR. -- Alexandr Ciornii, http://chorny.net
Subject: Perl-Metrics-Simple-patch.zip

Message body not shown because it is not plain text.

On Thu Feb 04 16:12:08 2010, CHORNY wrote: Show quoted text
> IMHO, best would be to let Perl::Metrics::Simple accept either text in > form of scalar ref (as PPI::Document does) or PPI::Document object.
That seems very reasonable. I looked at the patches quickly today and they seem fine. I'll look more carefully and hopefully add them this weekend. -M
I've applied the patches and uploaded a new release, 0.14 to CPAN. It should be available soon. Thanks again!