Hi!
On Sun, Jan 31, 2010 at 01:42:38AM -0500, Tokuhiro Matsuno via RT wrote:
Show quoted text> Sun Jan 31 01:42:37 2010: Request 54162 was acted upon.
> Transaction: Ticket created by TOKUHIROM
> Queue: AnyEvent-IRC
> Subject: /kick enhancements
> Broken in: (no value)
> Severity: (no value)
> Owner: Nobody
> Requestors: tokuhirom+cpan@gmail.com
> Status: new
> Ticket <URL:
https://rt.cpan.org/Ticket/Display.html?id=54162 >
>
>
> 'kick' event have following issues:
> - The document about 'kick' is broken.
> - 'kick' event doesn't send correct $msg.
> - 'kick' event should pass the $kicker_nick.
>
> I wrote a patch set and put it on github:
>
http://github.com/tokuhirom/p5-AnyEvent-IRC/commits/master
Great! I just pulled them, they are really ok. Just the 13_kick.t test has
a minor race condition. The problem is, that you can't be sure which bot gets
OP in the channel, as the order they join is not forced (at least thats what I
saw when skimming over the code).
I'll fix it when I stumble upon the bug when testing for the next release.
Thanks for the bug report and the patches!
Greetings,
Robin
--
Robin Redeker | Deliantra, the free code+content MORPG
elmex@ta-sa.org / r.redeker@gmail.com |
http://www.deliantra.net
http://www.ta-sa.org/ |
