Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the XSLoader CPAN distribution.

Report information
The Basics
Id: 54132
Status: resolved
Priority: 0/
Queue: XSLoader

People
Owner: Nobody in particular
Requestors: toddr [...] null.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.10
Fixed in: 0.14



Subject: XSLoader breaks with use version 0.81
XSLoader will break if someone installs version 0.81 which will probably shortly be on CPAN after perl 5.12 releases. This will break some of your tests. I've attached a patch to correct this.
Subject: XSLoader.patch
diff --git a/t/XSLoader.t b/t/XSLoader.t index bce7b0e..eb9b648 100644 --- a/t/XSLoader.t +++ b/t/XSLoader.t @@ -9,6 +9,7 @@ BEGIN { use strict; use Config; +use version; my $db_file; BEGIN { @@ -73,8 +74,14 @@ for my $module (sort keys %modules) { skip "$module not available", 4 if $extensions !~ /\b$module\b/; eval qq{ package $module; XSLoader::load('$module', "qunckkk"); }; - like( $@, "/^$module object version \\S+ does not match bootstrap parameter (?:qunckkk|0)/", + if("$version::VERSION" > 0.80) { # version traps this error message as of 0.81 + like( $@, qr/^Invalid\sversion\sformat\s\(non-numeric\sdata\)\s/, "calling XSLoader::load() with a XS module and an incorrect version" ); + } else { + like( $@, "/^$module object version \\S+ does not match bootstrap parameter (?:qunckkk|0)/", + "calling XSLoader::load() with a XS module and an incorrect version" ); + } + like( $warnings, "/^\$|^Version string 'qunckkk' contains invalid data; ignoring: 'qunckkk'/", "in Perl 5.10, DynaLoader warns about the incorrect version string" );
Subject: XSLoader tests break with use version 0.81
From: toddr [...] null.net
Changing subject
It seems that the XSLoader test was also fixed in perl's core, see commit 91152fc19d1c59a1213e39f74ac8a80f4a015f5e. The patch there is slightly different, but it looks as it is still backwards compatible with older perls. Regards, Slaven
Subject: Re: [rt.cpan.org #54132] XSLoader breaks with use version 0.81
Date: Sat, 16 Apr 2011 14:37:51 +0200
To: bug-XSLoader [...] rt.cpan.org
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
Slaven_Rezic wrote via RT: Show quoted text
> It seems that the XSLoader test was also fixed in perl's core, see > commit > 91152fc19d1c59a1213e39f74ac8a80f4a015f5e. The patch there is slightly > different, but it looks as it is still backwards compatible with older > perls.
This problem should be fixed with the release 0.14, just uploaded on the CPAN, sponsored by the Perl QA Hackathon 2011 in Amsterdam. My apologies for being late. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.