Skip Menu |

This queue is for tickets about the IO-Prompt CPAN distribution.

Report information
The Basics
Id: 54072
Status: open
Priority: 0/
Queue: IO-Prompt

People
Owner: Nobody in particular
Requestors: pjs [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: v0.99.4
Fixed in: (no value)



Subject: Not warnings safe with normal usage
It seems to me that this test should not throw warnings: $ perl -MIO::Prompt -we '$p = prompt(-p=>"Password: " -e => "*" ); print $p' Use of uninitialized value $_ in pattern match (m//) at /usr/local/lib/perl5/site_perl/5.10.0/IO/Prompt.pm line 92. Use of uninitialized value $_ in pattern match (m//) at /usr/local/lib/perl5/site_perl/5.10.0/IO/Prompt.pm line 92. Also, the line number reported is weird: $ cat -n /usr/local/lib/perl5/site_perl/5.10.0/IO/Prompt.pm | head -100 | tail -10 91 local *_ = \($data[$i]); 92 if (ref eq 'HASH') { 93 splice @data, $i + 1, 0, %$_; 94 } 95 elsif (ref eq 'GLOB' or UNIVERSAL::isa($_, 'IO::Handle')) { 96 croak "Can't write prompt to read-only $_" unless -w; 97 $OUT = $_; 98 } 99 elsif (/^-/) { # a flag 100 s/_//g;
Subject: Re: [rt.cpan.org #54072] Not warnings safe with normal usage
Date: Fri, 29 Jan 2010 06:41:33 +1100
To: bug-IO-Prompt [...] rt.cpan.org
From: Damian Conway <damian [...] conway.org>
Hi Peter, Show quoted text
> Broken in: v0.99.4 > It seems to me that this test should not throw warnings:
I believe this was fixed in the 0.996 release. Please let me know if you find otherwise. Damian
Subject: Re: [rt.cpan.org #54072] Not warnings safe with normal usage
Date: Fri, 29 Jan 2010 04:38:49 -0800
To: bug-IO-Prompt [...] rt.cpan.org
From: Peter Scott <peter [...] psdt.com>
Hi Damian, Show quoted text
><URL: https://rt.cpan.org/Ticket/Display.html?id=54072 > > >Hi Peter, >
>> Broken in: v0.99.4 >> It seems to me that this test should not throw warnings:
> >I believe this was fixed in the 0.996 release. >Please let me know if you find otherwise.
Otherwise... [peter@tweety ~]$ pmver IO::Prompt 0.996 [peter@tweety ~]$ perl -MIO::Prompt -we '$p = prompt(-p=>"Password: ", -e => "*"); print $p' Use of uninitialized value $_ in pattern match (m//) at /usr/local/lib/perl5/site_perl/5.10.0/IO/Prompt.pm line 92. Use of uninitialized value $_ in pattern match (m//) at /usr/local/lib/perl5/site_perl/5.10.0/IO/Prompt.pm line 92. Password: ***** fnord[peter@tweety ~]$
Subject: Re: [rt.cpan.org #54072] Not warnings safe with normal usage
Date: Sat, 30 Jan 2010 07:20:50 +1100
To: bug-IO-Prompt [...] rt.cpan.org
From: Damian Conway <damian [...] conway.org>
Show quoted text
>>I believe this was fixed in the 0.996 release. >>Please let me know if you find otherwise.
> > Otherwise...
Thanks, Peter. I just uploaded 0.997 which appears to fix this bug. (BTW, the total fix was exactly one character difference!) Let me know how it goes for you. Damian