Skip Menu |

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 54063
Status: resolved
Priority: 0/
Queue: DBIx-Class
People
Owner: Nobody in particular
Requestors: GHENRY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.08115
Fixed in: 0.08121

History Show all quoted text
  Thu Jan 28 10:28:26 2010 GHENRY [...] cpan.org - Ticket created
Subject: create_ddl_dir - slightly misleading
sub create_ddl_dir { my ($self, $schema, $databases, $version, $dir, $preversion, $sqltargs) = @_; if(!$dir || !-d $dir) { carp "No directory given, using ./\n"; $dir = "./"; } I think this should say: carp "No directory given or directory does not exist, using ./ instead\n"; I though it would create what I passed in. Thanks.
  Sat Mar 06 06:45:23 2010 ribasushi [...] leporine.io - Correspondence added
On Thu Jan 28 10:28:26 2010, GHENRY wrote: Show quoted text
> sub create_ddl_dir { > my ($self, $schema, $databases, $version, $dir, $preversion, > $sqltargs) = @_; > > if(!$dir || !-d $dir) { > carp "No directory given, using ./\n"; > $dir = "./"; > } > > > > I think this should say: > > carp "No directory given or directory does not exist, using ./ instead\n"; > > I though it would create what I passed in. > > Thanks.
Fixed in a slightly different way: http://dev.catalystframework.org/svnweb/bast/revision?rev=8906#diff__DBIx-Class_0.08_trunk_lib_DBIx_Class_Storage_DBI.pm
  Sat Mar 06 06:45:24 2010 The RT System itself - Status changed from 'new' to 'open'
  Sat Mar 06 06:45:24 2010 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'
  Sun Apr 11 17:34:39 2010 ribasushi [...] leporine.io - Fixed in 0.08121 added
  Sun Apr 11 17:34:40 2010 ribasushi [...] leporine.io - Correspondence added
DBIC 0.08121 shipped containing a fix for this bug.
  Sun Apr 11 17:34:41 2010 The RT System itself - Status changed from 'patched' to 'open'
  Sun Apr 11 17:34:41 2010 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'