Bug #53982 for DBIx-Class: Multi-insert and AutoCommit=0 regression

Mon Jan 25 13:29:06 2010 NWELLNHOF [...] cpan.org - Ticket created

Subject:

Multi-insert and AutoCommit=0 regression

I just upgraded from DBIx::Class 0.08108 to 0.08115 and I think I found a regression. I'm using AutoCommit=0 and when I try to do create a new row with related rows I get the following error: "DBIx::Class::ResultSet::create(): DBI Exception: DBD::mysql::db begin_work failed: Already in a transaction" Some sample code that triggers the error: use My::Schema; my $schema = My::Schema->connection( $dsn, $user, $pass, { AutoCommit => 0 } ); $schema->resultset('MyResultset')->create({ category => 'test', date => 0, contents => [ { lang => 'en', title => 'Test' } ], }); When I set AutoCommit=1 or when I don't create the related row for "contents" everything works fine.

Mon Jan 25 19:25:44 2010 frioux [...] gmail.com - Correspondence added

On Mon Jan 25 13:29:06 2010, NWELLNHOF wrote: Show quoted text

> I just upgraded from DBIx::Class 0.08108 to 0.08115 and I think I found > a regression. I'm using AutoCommit=0 and when I try to do create a new > row with related rows I get the following error: > > "DBIx::Class::ResultSet::create(): DBI Exception: DBD::mysql::db > begin_work failed: Already in a transaction" > > Some sample code that triggers the error: > > use My::Schema; > my $schema = My::Schema->connection( > $dsn, $user, $pass, { AutoCommit => 0 } > ); > $schema->resultset('MyResultset')->create({ > category => 'test', > date => 0, > contents => [ { lang => 'en', title => 'Test' } ], > }); > > When I set AutoCommit=1 or when I don't create the related row for > "contents" everything works fine.

The error message on that could probably be better, but I think what's happening is that multicreate (creating with related stuff as above) does an implicit transaction, and transactions in DBIC are nicer if you have AutoCommit on. From DBIx::Class::Schema: WARNING: If you are connected with AutoCommit => 0 the transaction is considered nested, and you will still need to call "txn_commit" to write your changes when appropriate. You will also want to connect with auto_savepoint => 1 to get partial rollback to work, if the storage driver for your database supports it. Connecting with AutoCommit => 1 is recommended.

Mon Jan 25 19:25:46 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 26 03:18:39 2010 ribasushi [...] leporine.io - Taken

Tue Jan 26 03:19:05 2010 ribasushi [...] leporine.io - Correspondence added

On Mon Jan 25 13:29:06 2010, NWELLNHOF wrote: Show quoted text

> I just upgraded from DBIx::Class 0.08108 to 0.08115 and I think I found > a regression. I'm using AutoCommit=0 and when I try to do create a new > row with related rows I get the following error: > > "DBIx::Class::ResultSet::create(): DBI Exception: DBD::mysql::db > begin_work failed: Already in a transaction" > > Some sample code that triggers the error: > > use My::Schema; > my $schema = My::Schema->connection( > $dsn, $user, $pass, { AutoCommit => 0 } > ); > $schema->resultset('MyResultset')->create({ > category => 'test', > date => 0, > contents => [ { lang => 'en', title => 'Test' } ], > }); > > When I set AutoCommit=1 or when I don't create the related row for > "contents" everything works fine.

This is a bug, DBIC should behave correctly when you use AutoCommit=0. It will be fixed in the next release, in the meantime either of the two workarounds will work for you.

Tue Jan 26 04:10:54 2010 ribasushi [...] leporine.io - Correspondence added

Fixed by http://dev.catalyst.perl.org/svnweb/bast/revision?rev=8426 Cheers

Tue Jan 26 04:11:02 2010 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'

Tue Jan 26 18:19:04 2010 NWELLNHOF [...] cpan.org - Correspondence added

On Tue Jan 26 04:10:54 2010, RIBASUSHI wrote: Show quoted text

> Fixed by http://dev.catalyst.perl.org/svnweb/bast/revision?rev=8426 > > Cheers

Thanks for the quick fix. It works for me.

Tue Jan 26 18:19:05 2010 The RT System itself - Status changed from 'patched' to 'open'

Thu Jan 28 06:18:26 2010 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'

Fri Feb 05 17:37:27 2010 ribasushi [...] leporine.io - Fixed in 0.08117 added

Fri Feb 05 17:37:27 2010 ribasushi [...] leporine.io - Status changed from 'patched' to 'resolved'