Skip Menu |

This queue is for tickets about the Config-JFDI CPAN distribution.

Report information
The Basics
Id: 53886
Status: open
Priority: 0/
Queue: Config-JFDI

People
Owner: Nobody in particular
Requestors: mzrinsky [...] redanvil.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.064
Fixed in: (no value)



Subject: local_suffix file warning.
The warning "'local_suffix' will be ignored if 'file' is given ..." is produced when setting local_suffix, even if NOT setting file. Attached a patch to warn if you are using local_suffix AND file.
Subject: JFDI_local_suffix_warning.patch
--- a/Config/JFDI.pm 2009-10-18 23:34:25.000000000 -0500 +++ b/Config/JFDI.pm 2010-01-14 09:08:16.000000000 -0600 @@ -214,7 +214,7 @@ sub BUILD { $source{$_} = $given->{$_} if exists $given->{$_}; } - carp "Warning, 'local_suffix' will be ignored if 'file' is given, use 'path' instead" if exists $source{local_suffix}; + carp "Warning, 'local_suffix' will be ignored if 'file' is given, use 'path' instead" if exists $source{local_suffix} && exists $source{file}; $source{local_suffix} = $given->{config_local_suffix} if $given->{config_local_suffix};
On Thu Jan 21 11:42:00 2010, pldoh wrote: Show quoted text
> Attached a patch to warn if you are using local_suffix AND file.
I ran into this same issue today. Any chance this patch can be applied? Thanks, Russell. ps. I'd be happy to send a push request from github, though master branch there is still 0.063_3.. Let me know if there is anything else I can do to help get this applied.
On Tue Dec 28 19:27:13 2010, RUSSELLJ wrote: Show quoted text
> On Thu Jan 21 11:42:00 2010, pldoh wrote:
> > Attached a patch to warn if you are using local_suffix AND file.
> > I ran into this same issue today. Any chance this patch can be > applied? > > Thanks, Russell. > > ps. I'd be happy to send a push request from github, though master > branch there is still > 0.063_3.. Let me know if there is anything else I can do to help get > this applied.
Thanks for the reminder. I've integrated the fix and am pushing up a development release now I've also updated the github repository to the latest version