Bug #53770 for IO: binmode does not accept 1 or 2 parameters but this are the typical calls.

Sun Jan 17 02:43:17 2010 STEFFENW [...] cpan.org - Ticket created

Subject:

binmode does not accept 1 or 2 parameters but this are the typical calls.

Please change IO::File 1.14 from 0196: ( @_ == 1 or @_ == 2 ) or croak 'usage $fh->binmode([LAYER])'; to 0196: ( @_ == 1 && @_ == 2 ) or croak 'usage $fh->binmode([LAYER])';

Sun Jan 17 03:37:20 2010 STEFFENW [...] cpan.org - Correspondence added

And there is a second problem with sub binmode. The closing bracket at the end of th sub is missing. This locks like untested.

Sun Jan 17 03:46:44 2010 STEFFENW [...] cpan.org - Correspondence added

Ignore the 2nd. I have no idea why I could not see the bracket. At the current version the bracket was written.

Mon Jan 18 15:34:07 2010 gbarr [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #53770] binmode does not accept 1 or 2 parameters but this are the typical calls.
Date:	Mon, 18 Jan 2010 14:33:39 -0600
To:	bug-IO [...] rt.cpan.org
From:	Graham Barr <gbarr [...] pobox.com>

On Jan 17, 2010, at 1:43 AM, Steffen Winkler via RT wrote: Show quoted text

> > Please change IO::File 1.14 from > > 0196: ( @_ == 1 or @_ == 2 ) or croak 'usage $fh->binmode([LAYER])'; > > to > > 0196: ( @_ == 1 && @_ == 2 ) or croak 'usage $fh->binmode([LAYER])';

Did you test this ? that will croak one EVERY call Graham.

Mon Jan 18 15:34:10 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 19 06:29:28 2010 STEFFENW [...] cpan.org - Correspondence added

Excuse me. Maybe I lost my brain.

Thu Apr 19 18:36:26 2018 TODDR [...] cpan.org - Correspondence added

Ticket migrated to github as https://github.com/toddr/IO/issues/37

Thu Apr 19 18:36:27 2018 TODDR [...] cpan.org - Status changed from 'open' to 'resolved'