Skip Menu |

This queue is for tickets about the Schedule-Cron CPAN distribution.

Report information
The Basics
Id: 53732
Status: resolved
Priority: 0/
Queue: Schedule-Cron

People
Owner: Nobody in particular
Requestors: perl [...] events.soundwave.net
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.99
Fixed in: (no value)



Subject: t/execution_time.t skips all tests after TZBEGIN
Hi there, In t/execution_time.t, if $skip gets set then the rest of DATA is skipped. TZEND has no effect. The fix is to move the "next if $skip" down a bit. This leaves a minor bug of reading in Reftime lines even while skipping, but one might expect that the line following TZEND is a fresh Reftime anyway. Thanks, William
Subject: execution_time.t.patch
diff -ur Schedule-Cron-0.99/t/execution_time.t Schedule-Cron-0.99.patch/t/execution_time.t --- Schedule-Cron-0.99/t/execution_time.t 2009-09-12 00:19:15.000000000 -0700 +++ Schedule-Cron-0.99.patch/t/execution_time.t 2010-01-15 13:33:45.000000000 -0800 @@ -20,7 +20,6 @@ my $skip = 0; while (defined($_=<DATA>) && $_ !~ /^end/i) { chomp; - next if $skip; if (/^Reftime:\s*(.*)$/) { $time = $1; $time =~ s/\#.*$//; @@ -35,6 +34,7 @@ $skip = 0; next; } + next if $skip; s/^\s*(.*)\s*/$1/; next if /^\#/ || /^$/; my @args = split(/\s+/,$_,6);
Hi William, On Fri Jan 15 16:54:34 2010, wmono wrote: Show quoted text
> In t/execution_time.t, if $skip gets set then the rest of DATA is > skipped. TZEND has no effect. The fix is to move the "next if $skip" > down a bit. > > This leaves a minor bug of reading in Reftime lines even while skipping, > but one might expect that the line following TZEND is a fresh Reftime > anyway.
You are absolutely right. Thanks for your patch, this will be in the final 1.00 release (which I will do rather soon, hopefully).
 Fixed in 1.00