Bug #53634 for Catalyst-TraitFor-Model-DBIC-Schema-QueryLog: Please either set $querylog->passthrough to 1 or allow it to be set

Tue Jan 12 18:29:41 2010 nigel [...] mcnie.name - Ticket created

Subject:	Please either set $querylog->passthrough to 1 or allow it to be set
Date:	Wed, 13 Jan 2010 12:29:11 +1300
To:	bug-Catalyst-TraitFor-Model-DBIC-Schema-QueryLog [...] rt.cpan.org
From:	Nigel McNie <nigel [...] mcnie.name>

I am using Catalyst::TraitFor::Model::DBIC::Schema::QueryLog version 0.0.2 from CPAN (and later debianised). When you enable the use of this module, it surpresses the lines normally emitted by setting DBIC_TRACE=1. This can be fixed by adding $querylog->passthrough(1); to build_per_context_instance just after $querylog is made. Would it be possible for this to be done, or for an option to be provided so people can choose whether passthrough is enabled? -- Regards, Nigel McNie

Tue Jan 12 18:59:15 2010 fayland [...] cpan.org - Correspondence added

can you try http://fayland.org/CPAN/Catalyst-TraitFor-Model-DBIC-Schema-QueryLog-0.03.tar.gz __PACKAGE__->config({ traits => ['QueryLog'] connect_info => ['dbi:mysql:master', 'user', 'pass'], querylog_args => { passthrough => 1, }, }); if everything is OK, I'll upload it to CPAN. Thanks.

Tue Jan 12 18:59:16 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 12 21:14:10 2010 nigel [...] mcnie.name - Correspondence added

Subject:	Re: [rt.cpan.org #53634] Please either set $querylog->passthrough to 1 or allow it to be set
Date:	Wed, 13 Jan 2010 15:13:43 +1300
To:	bug-Catalyst-TraitFor-Model-DBIC-Schema-QueryLog [...] rt.cpan.org
From:	Nigel McNie <nigel [...] mcnie.name>

2010/1/13 Fayland Lin via RT <bug-Catalyst-TraitFor-Model-DBIC-Schema-QueryLog@rt.cpan.org>: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=53634 > > > can you try > http://fayland.org/CPAN/Catalyst-TraitFor-Model-DBIC-Schema-QueryLog-0.03.tar.gz

Magic, it works fine :) Show quoted text

> __PACKAGE__->config({ > traits => ['QueryLog'] > connect_info => > ['dbi:mysql:master', 'user', 'pass'], > querylog_args => { > passthrough => 1, > }, > });

I did notice in this example (and in the ones you have in the pod) that you're missing a comma after ['QueryLog']. Other than that, looks great. -- Regards, Nigel McNie

Tue Jan 12 21:30:31 2010 fayland [...] cpan.org - Correspondence added

Thanks. POD fixed and new version is uploaded to CPAN. :)

Tue Jan 12 21:30:34 2010 fayland [...] cpan.org - Status changed from 'open' to 'resolved'